[coreboot-gerrit] Change in coreboot[master]: nb/intel/sandybridge: Don't add SMBIOS Table 17 entries on resume

Felix Held (Code Review) gerrit at coreboot.org
Fri Sep 14 22:17:13 CEST 2018


Felix Held has submitted this change and it was merged. ( https://review.coreboot.org/28589 )

Change subject: nb/intel/sandybridge: Don't add SMBIOS Table 17 entries on resume
......................................................................

nb/intel/sandybridge: Don't add SMBIOS Table 17 entries on resume

Change-Id: Icac6e696efa1721933a1963b45d608d9ae735149
Signed-off-by: Nico Huber <nico.huber at secunet.com>
Reviewed-on: https://review.coreboot.org/28589
Tested-by: build bot (Jenkins) <no-reply at coreboot.org>
Reviewed-by: Patrick Rudolph <siro at das-labor.org>
Reviewed-by: Nathaniel Roach <nroach44 at gmail.com>
Reviewed-by: Evgeny Zinoviev <me at ch1p.com>
---
M src/northbridge/intel/sandybridge/raminit.c
1 file changed, 2 insertions(+), 1 deletion(-)

Approvals:
  build bot (Jenkins): Verified
  Patrick Rudolph: Looks good to me, approved
  Nathaniel Roach: Looks good to me, but someone else must approve
  Evgeny Zinoviev: Looks good to me, but someone else must approve



diff --git a/src/northbridge/intel/sandybridge/raminit.c b/src/northbridge/intel/sandybridge/raminit.c
index 0f72d88..46d5de8 100644
--- a/src/northbridge/intel/sandybridge/raminit.c
+++ b/src/northbridge/intel/sandybridge/raminit.c
@@ -437,7 +437,8 @@
 		halt();
 	}
 
-	fill_smbios17(&ctrl);
+	if (!s3resume)
+		fill_smbios17(&ctrl);
 }
 
 void perform_raminit(int s3resume)

-- 
To view, visit https://review.coreboot.org/28589
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Icac6e696efa1721933a1963b45d608d9ae735149
Gerrit-Change-Number: 28589
Gerrit-PatchSet: 2
Gerrit-Owner: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: Evgeny Zinoviev <me at ch1p.com>
Gerrit-Reviewer: Felix Held <felix-coreboot at felixheld.de>
Gerrit-Reviewer: Nathaniel Roach <nroach44 at gmail.com>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180914/c6815327/attachment.html>


More information about the coreboot-gerrit mailing list