[coreboot-gerrit] Change in coreboot[master]: mb/intel/coffeelake_rvp: GPIO support for whiskey board

[Lijian Zhao (Code Review)]

Lijian Zhao has posted comments on this change. ( https://review.coreboot.org/28367 )

Change subject: mb/intel/coffeelake_rvp: GPIO support for whiskey board
......................................................................


Patch Set 2:

(1 comment)

https://review.coreboot.org/#/c/28367/2/src/mainboard/intel/coffeelake_rvp/variants/baseboard/gpio.c
File src/mainboard/intel/coffeelake_rvp/variants/baseboard/gpio.c:

https://review.coreboot.org/#/c/28367/2/src/mainboard/intel/coffeelake_rvp/variants/baseboard/gpio.c@266
PS2, Line 266: #if IS_ENABLED(CONFIG_BOARD_INTEL_WHISKEYLAKE_RVP)
             : 	PAD_CFG_GPO(GPP_H22, 1, PLTRST),
             : #endif
> With this GPP_H22 gets programmed 2 times for WHISKEYLAKE_RVP, keep #if and #else ?
Done



-- 
To view, visit https://review.coreboot.org/28367
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I35a0384f828fd3219e0c3adb4830f5bdab800e32
Gerrit-Change-Number: 28367
Gerrit-PatchSet: 2
Gerrit-Owner: Lijian Zhao <lijian.zhao at intel.com>
Gerrit-Reviewer: Bora Guvendik <bora.guvendik at intel.com>
Gerrit-Reviewer: Hannah Williams <hannah.williams at intel.com>
Gerrit-Reviewer: Krzysztof M Sywula <krzysztof.m.sywula at intel.com>
Gerrit-Reviewer: Lijian Zhao <lijian.zhao at intel.com>
Gerrit-Reviewer: Pratikkumar V Prajapati <pratikkumar.v.prajapati at intel.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik at intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Fri, 14 Sep 2018 19:30:52 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180914/c0d24de5/attachment.html>