[coreboot-gerrit] Change in coreboot[master]: soc/sifive/fu540: Switch clock to 1GHz in romstage

[build bot (Jenkins) (Code Review)]

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/28602 )

Change subject: soc/sifive/fu540: Switch clock to 1GHz in romstage
......................................................................


Patch Set 1:

(4 comments)

https://review.coreboot.org/#/c/28602/1/src/soc/sifive/fu540/clock.c
File src/soc/sifive/fu540/clock.c:

https://review.coreboot.org/#/c/28602/1/src/soc/sifive/fu540/clock.c@209
PS1, Line 209: void static update_peripheral_clock_dividers(void)
storage class 'static' should be located before type 'void'


https://review.coreboot.org/#/c/28602/1/src/soc/sifive/fu540/clock.c@215
PS1, Line 215: 	for (size_t i = 0; i < FU540_UART_DEVICES; i++) {
braces {} are not necessary for single statement blocks


https://review.coreboot.org/#/c/28602/1/src/soc/sifive/fu540/clock.c@216
PS1, Line 216: 		write32((uint32_t *)(FU540_UART(i) + FU540_UART_REG_DIV), FU540_UART_DIV_VAL);
line over 80 characters


https://review.coreboot.org/#/c/28602/1/src/soc/sifive/fu540/clock.c@224
PS1, Line 224:          * values as we can't put them in reset before changing frequency.
code indent should use tabs where possible



-- 
To view, visit https://review.coreboot.org/28602
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib869762d557e8fdf4c83a53698102df116d80389
Gerrit-Change-Number: 28602
Gerrit-PatchSet: 1
Gerrit-Owner: Philipp Hug <philipp at hug.cx>
Gerrit-CC: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Fri, 14 Sep 2018 08:33:06 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180914/551ace23/attachment.html>