[coreboot-gerrit] Change in coreboot[master]: soc/sifive/fu540: create ram_resource with actual memory size

[build bot (Jenkins) (Code Review)]

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/28592 )

Change subject: soc/sifive/fu540: create ram_resource with actual memory size
......................................................................


Patch Set 1:

(6 comments)

https://review.coreboot.org/#/c/28592/1/src/soc/sifive/fu540/soc.c
File src/soc/sifive/fu540/soc.c:

https://review.coreboot.org/#/c/28592/1/src/soc/sifive/fu540/soc.c@18
PS1, Line 18:         ram_resource(dev, 0, (uintptr_t)_dram/KiB,
code indent should use tabs where possible


https://review.coreboot.org/#/c/28592/1/src/soc/sifive/fu540/soc.c@18
PS1, Line 18:         ram_resource(dev, 0, (uintptr_t)_dram/KiB,
please, no spaces at the start of a line


https://review.coreboot.org/#/c/28592/1/src/soc/sifive/fu540/soc.c@19
PS1, Line 19:                 (sdram_max_addressable_mb() - fb_size)*KiB -
code indent should use tabs where possible


https://review.coreboot.org/#/c/28592/1/src/soc/sifive/fu540/soc.c@19
PS1, Line 19:                 (sdram_max_addressable_mb() - fb_size)*KiB -
please, no spaces at the start of a line


https://review.coreboot.org/#/c/28592/1/src/soc/sifive/fu540/soc.c@20
PS1, Line 20:                 (uintptr_t)_dram/KiB);
code indent should use tabs where possible


https://review.coreboot.org/#/c/28592/1/src/soc/sifive/fu540/soc.c@20
PS1, Line 20:                 (uintptr_t)_dram/KiB);
please, no spaces at the start of a line



-- 
To view, visit https://review.coreboot.org/28592
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If6af6f679e24e56c79b995de0970d4e6f455e40a
Gerrit-Change-Number: 28592
Gerrit-PatchSet: 1
Gerrit-Owner: Philipp Hug <philipp at hug.cx>
Gerrit-CC: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Thu, 13 Sep 2018 14:15:32 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180913/3374f64a/attachment.html>