[coreboot-gerrit] Change in coreboot[master]: soc/amd/stoneyridge/gpio.c: Create I2C slave reset code
build bot (Jenkins) (Code Review)
gerrit at coreboot.org
Tue Sep 11 19:20:29 CEST 2018
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/28571 )
Change subject: soc/amd/stoneyridge/gpio.c: Create I2C slave reset code
......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/#/c/28571/1/src/soc/amd/stoneyridge/gpio.c
File src/soc/amd/stoneyridge/gpio.c:
https://review.coreboot.org/#/c/28571/1/src/soc/amd/stoneyridge/gpio.c@352
PS1, Line 352: while(remain) {
space required before the open parenthesis '('
https://review.coreboot.org/#/c/28571/1/src/soc/amd/stoneyridge/include/soc/gpio.h
File src/soc/amd/stoneyridge/include/soc/gpio.h:
https://review.coreboot.org/#/c/28571/1/src/soc/amd/stoneyridge/include/soc/gpio.h@39
PS1, Line 39: struct soc_amd_i2c_save{
missing space after struct definition
--
To view, visit https://review.coreboot.org/28571
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I825b6380fb658c3ea5fc669117ae04d2dc181819
Gerrit-Change-Number: 28571
Gerrit-PatchSet: 1
Gerrit-Owner: Richard Spiegel <richard.spiegel at silverbackltd.com>
Gerrit-CC: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Tue, 11 Sep 2018 17:20:29 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180911/04950f80/attachment.html>
More information about the coreboot-gerrit
mailing list