[coreboot-gerrit] Change in coreboot[master]: util/board_status: Add support of CMOS values dump

build bot (Jenkins) (Code Review) gerrit at coreboot.org
Mon Sep 10 23:06:21 CEST 2018


build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/28565 )

Change subject: util/board_status: Add support of CMOS values dump
......................................................................


Patch Set 1:

(5 comments)

https://review.coreboot.org/#/c/28565/1/util/board_status/board_status.sh
File util/board_status/board_status.sh:

https://review.coreboot.org/#/c/28565/1/util/board_status/board_status.sh@30
PS1, Line 30: # Used if nvramtool is not in default $PATH, e.g. not installed or when using `sudo`
line over 80 characters


https://review.coreboot.org/#/c/28565/1/util/board_status/board_status.sh@383
PS1, Line 383: if grep -q "CONFIG_USE_OPTION_TABLE=y" "${tmpdir}/${results}/config.short.txt" > /dev/null; then
line over 80 characters


https://review.coreboot.org/#/c/28565/1/util/board_status/board_status.sh@407
PS1, Line 407: 		cmd $REMOTE "$nvramtool_cmd -a" "${tmpdir}/${results}/cmos_values.txt"
line over 80 characters


https://review.coreboot.org/#/c/28565/1/util/board_status/board_status.sh@437
PS1, Line 437: 				echo "Failed to run $nvramtool_cmd. Check \$PATH or" \
line over 80 characters


https://review.coreboot.org/#/c/28565/1/util/board_status/board_status.sh@448
PS1, Line 448: 		cmd $LOCAL "$nvramtool_cmd -a" "${tmpdir}/${results}/cmos_values.txt"
line over 80 characters



-- 
To view, visit https://review.coreboot.org/28565
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I89f9a0e9622557b01dda52378f8f1323777bce39
Gerrit-Change-Number: 28565
Gerrit-PatchSet: 1
Gerrit-Owner: Evgeny Zinoviev <me at ch1p.com>
Gerrit-CC: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Mon, 10 Sep 2018 21:06:21 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180910/d00f8e12/attachment.html>


More information about the coreboot-gerrit mailing list