[coreboot-gerrit] Change in coreboot[master]: soc/sifive: fix compiler warning

Patrick Georgi (Code Review) gerrit at coreboot.org
Mon Sep 10 22:37:25 CEST 2018


Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/28553 )

Change subject: soc/sifive: fix compiler warning
......................................................................

soc/sifive: fix compiler warning

Fix the following compiler warning on the latest toolchain:
src/soc/sifive/fu540/otp.c:48:1: error: useless storage class specifier in empty declaration [-Werror]
 } __packed;
 ^

Change-Id: Ice87c821de7650ac547394efa2a4bcc5ae1ea668
Signed-off-by: Philipp Hug <philipp at hug.cx>
Reviewed-on: https://review.coreboot.org/28553
Tested-by: Patrick Georgi <pgeorgi at google.com>
Reviewed-by: Patrick Georgi <pgeorgi at google.com>
---
M src/soc/sifive/fu540/otp.c
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Patrick Georgi: Verified; Looks good to me, approved



diff --git a/src/soc/sifive/fu540/otp.c b/src/soc/sifive/fu540/otp.c
index e6900fe..73a5573 100644
--- a/src/soc/sifive/fu540/otp.c
+++ b/src/soc/sifive/fu540/otp.c
@@ -29,7 +29,7 @@
  * https://www.sifive.com/documentation/chips/freedom-u540-c000-manual/
  */
 
-typedef struct sifive_otp_registers {
+struct sifive_otp_registers {
 	u32 pa;     /* Address input */
 	u32 paio;   /* Program address input */
 	u32 pas;    /* Program redundancy cell selection input */

-- 
To view, visit https://review.coreboot.org/28553
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ice87c821de7650ac547394efa2a4bcc5ae1ea668
Gerrit-Change-Number: 28553
Gerrit-PatchSet: 2
Gerrit-Owner: Philipp Hug <philipp at hug.cx>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: Philipp Hug <philipp at hug.cx>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180910/1164d79a/attachment.html>


More information about the coreboot-gerrit mailing list