[coreboot-gerrit] Change in coreboot[master]: qemu-q35: Use the TSC for udelay

Philipp Deppenwiese (Code Review) gerrit at coreboot.org
Thu Sep 6 18:31:16 CEST 2018


Philipp Deppenwiese has submitted this change and it was merged. ( https://review.coreboot.org/28526 )

Change subject: qemu-q35: Use the TSC for udelay
......................................................................

qemu-q35: Use the TSC for udelay

Use the TSC for delays on q35, ensuring that the TSC delay code is
included in the correct stages when selected.

Tested on qemu-35 and wedge-100s (for no regressions).

Change-Id: I3f8368509807974bfcf2a0fcff7a4aa21adf47ed
Signed-off-by: Michael van der Westhuizen <rmikey at fb.com>
Reviewed-on: https://review.coreboot.org/28526
Tested-by: build bot (Jenkins) <no-reply at coreboot.org>
Reviewed-by: Paul Menzel <paulepanter at users.sourceforge.net>
Reviewed-by: Patrick Rudolph <siro at das-labor.org>
Reviewed-by: Philipp Deppenwiese <zaolin.daisuki at gmail.com>
---
M src/cpu/qemu-x86/Kconfig
M src/cpu/qemu-x86/Makefile.inc
2 files changed, 2 insertions(+), 0 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Paul Menzel: Looks good to me, but someone else must approve
  Philipp Deppenwiese: Looks good to me, approved
  Patrick Rudolph: Looks good to me, approved



diff --git a/src/cpu/qemu-x86/Kconfig b/src/cpu/qemu-x86/Kconfig
index ea2bc46..ab8e1a9 100644
--- a/src/cpu/qemu-x86/Kconfig
+++ b/src/cpu/qemu-x86/Kconfig
@@ -20,3 +20,4 @@
 	select ARCH_ROMSTAGE_X86_32
 	select ARCH_RAMSTAGE_X86_32
 	select SMP
+	select UDELAY_TSC
diff --git a/src/cpu/qemu-x86/Makefile.inc b/src/cpu/qemu-x86/Makefile.inc
index b5f8369..288eea6 100644
--- a/src/cpu/qemu-x86/Makefile.inc
+++ b/src/cpu/qemu-x86/Makefile.inc
@@ -16,3 +16,4 @@
 subdirs-y += ../x86/mtrr
 subdirs-y += ../x86/lapic
 subdirs-y += ../x86/smm
+subdirs-y += ../x86/tsc

-- 
To view, visit https://review.coreboot.org/28526
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I3f8368509807974bfcf2a0fcff7a4aa21adf47ed
Gerrit-Change-Number: 28526
Gerrit-PatchSet: 2
Gerrit-Owner: Michael van der Westhuizen (1002100)
Gerrit-Reviewer: Michael van der Westhuizen (1002100)
Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph at 9elements.com>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki at gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: David Hendricks <david.hendricks at gmail.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180906/a6cde01b/attachment.html>


More information about the coreboot-gerrit mailing list