[coreboot-gerrit] Change in coreboot[master]: rammus: add SPD mapping for rammus and shyvana support.

[YanRu Chen (Code Review)]

YanRu Chen has posted comments on this change. ( https://review.coreboot.org/28484 )

Change subject: rammus: add SPD mapping for rammus and shyvana support.
......................................................................


Patch Set 1:

(1 comment)

The memory strapping table of rammus project start from 0b0001 to 0b0100. We don't have table for 0b000, so we copy 0b0001 setting to 0b0000 to follow your non empty requirement.

https://review.coreboot.org/#/c/28484/1/src/mainboard/google/poppy/variants/rammus/Makefile.inc
File src/mainboard/google/poppy/variants/rammus/Makefile.inc:

https://review.coreboot.org/#/c/28484/1/src/mainboard/google/poppy/variants/rammus/Makefile.inc@1
PS1, Line 1: samsung_dimm_K4E8E324EB-EGCF
> Memory ID 0 and 1 are using the same memory?
The memory strapping table of rammus project start from 0b0001 to 0b0100. We don't have table for 0b000, so we copy 0b0001 setting to 0b0000 to follow your non empty requirement.



-- 
To view, visit https://review.coreboot.org/28484
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7cb5b7f2bcdc6fbe0cbc640cad4af014f1a0edd6
Gerrit-Change-Number: 28484
Gerrit-PatchSet: 1
Gerrit-Owner: YanRu Chen <kane_chen at pegatron.corp-partner.google.com>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: YanRu Chen <kane_chen at pegatron.corp-partner.google.com>
Gerrit-Reviewer: Zhuohao Lee <zhuohao at chromium.org>
Gerrit-CC: Jerry Chou <jerry_chou at pegatron.corp-partner.google.com>
Gerrit-CC: Ken Lu <ken_lu at pegatron.corp-partner.google.com>
Gerrit-Comment-Date: Thu, 06 Sep 2018 06:58:34 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180906/4087d551/attachment.html>