[coreboot-gerrit] Change in coreboot[master]: x86/acpi: Add APEI definitions
Martin Roth (Code Review)
gerrit at coreboot.org
Wed Sep 5 00:09:15 CEST 2018
Martin Roth has posted comments on this change. ( https://review.coreboot.org/28469 )
Change subject: x86/acpi: Add APEI definitions
......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/#/c/28469/1/src/arch/x86/include/arch/acpi.h
File src/arch/x86/include/arch/acpi.h:
https://review.coreboot.org/#/c/28469/1/src/arch/x86/include/arch/acpi.h@660
PS1, Line 660: see Table 18-382
Add spec and version?
https://review.coreboot.org/#/c/28469/1/src/arch/x86/include/arch/acpi.h@693
PS1, Line 693: /* zero or more Generic Error Data Entries */
I don't understand what this comment is referring to.
--
To view, visit https://review.coreboot.org/28469
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib9f4e506080285a7c3de6a223632c6f70933e66c
Gerrit-Change-Number: 28469
Gerrit-PatchSet: 1
Gerrit-Owner: Marshall Dawson <marshalldawson3rd at gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Martin Roth <martinroth at google.com>
Gerrit-Comment-Date: Tue, 04 Sep 2018 22:09:15 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180904/c1548fec/attachment.html>
More information about the coreboot-gerrit
mailing list