[coreboot-gerrit] Change in coreboot[master]: src/include: Add CPER definitions

[Martin Roth (Code Review)]

Martin Roth has posted comments on this change. ( https://review.coreboot.org/28468 )

Change subject: src/include: Add CPER definitions
......................................................................


Patch Set 1: Code-Review+2

(1 comment)

https://review.coreboot.org/#/c/28468/1/src/include/cper.h
File src/include/cper.h:

https://review.coreboot.org/#/c/28468/1/src/include/cper.h@398
PS1, Line 398:  0x20;
Is there a reason you didn't use "bin2bcd(time.year / 100);"



-- 
To view, visit https://review.coreboot.org/28468
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I74d8ec8311de749e891827747b84dce0e737aceb
Gerrit-Change-Number: 28468
Gerrit-PatchSet: 1
Gerrit-Owner: Marshall Dawson <marshalldawson3rd at gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Tue, 04 Sep 2018 22:05:47 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180904/ca630af5/attachment.html>