[coreboot-gerrit] Change in coreboot[master]: arch/x86: Add BERT region support functions

Marshall Dawson (Code Review) gerrit at coreboot.org
Tue Sep 4 23:21:09 CEST 2018


Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/28470 )

Change subject: arch/x86: Add BERT region support functions
......................................................................


Patch Set 1:

(2 comments)

I'd meant to relook at the error reporting, i.e. make sure there aren't duplicates.

https://review.coreboot.org/#/c/28470/1/src/arch/x86/acpi_bert_storage.c
File src/arch/x86/acpi_bert_storage.c:

https://review.coreboot.org/#/c/28470/1/src/arch/x86/acpi_bert_storage.c@4
PS1, Line 4: 2015 Google Inc.
copy/paste fail


https://review.coreboot.org/#/c/28470/1/src/arch/x86/acpi_bert_storage.c@19
PS1, Line 19: todo
remove todo.  was left over from old location of this file



-- 
To view, visit https://review.coreboot.org/28470
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I54826981639b5647a8ca33b8b55ff097681402b9
Gerrit-Change-Number: 28470
Gerrit-PatchSet: 1
Gerrit-Owner: Marshall Dawson <marshalldawson3rd at gmail.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd at gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Tue, 04 Sep 2018 21:21:09 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180904/d9d77b39/attachment.html>


More information about the coreboot-gerrit mailing list