[coreboot-gerrit] Change in coreboot[master]: vendorcode/google/chromeos: Move enable_update from BS_PAYLOAD_LOAD t...

[Subrata Banik (Code Review)]

Subrata Banik has uploaded this change for review. ( https://review.coreboot.org/28465


Change subject: vendorcode/google/chromeos: Move enable_update from BS_PAYLOAD_LOAD to BS_WRITE_TABLES
......................................................................

vendorcode/google/chromeos: Move enable_update from BS_PAYLOAD_LOAD to BS_WRITE_TABLES

This patch changes the sequence of enable_update() function because
of post_cpus_init() is assume to be executed at very last of the stages,
i.e., ON_EXIT of BS_WRITE_TABLES for normal boot path, and to ON_ENTRY of
BS_OS_RESUME for S3 Resume path. But later with enable_update() function
introduction into BS_STATE machine execution its now gettings executed to
ON_ENTRY of BS_PAYLOAD_LOAD which is just next to BS_WRITE_TABLES state.
This leads to some rare cases when post_cpus_init() function is still on going
and enable_update() function is getting timeout.

TEST=enable_update() is gettings called before post_cpus_init() during
BS_STATE machine execution.

Change-Id: I85def7028bd21c8729b0f5857652900a3f848cdd
Signed-off-by: Subrata Banik <subrata.banik at intel.com>
---
M src/vendorcode/google/chromeos/cr50_enable_update.c
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/65/28465/1

diff --git a/src/vendorcode/google/chromeos/cr50_enable_update.c b/src/vendorcode/google/chromeos/cr50_enable_update.c
index d07a9a3..6e14522 100644
--- a/src/vendorcode/google/chromeos/cr50_enable_update.c
+++ b/src/vendorcode/google/chromeos/cr50_enable_update.c
@@ -71,4 +71,4 @@
 	}
 	halt();
 }
-BOOT_STATE_INIT_ENTRY(BS_PAYLOAD_LOAD, BS_ON_ENTRY, enable_update, NULL);
+BOOT_STATE_INIT_ENTRY(BS_WRITE_TABLES, BS_ON_ENTRY, enable_update, NULL);

-- 
To view, visit https://review.coreboot.org/28465
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I85def7028bd21c8729b0f5857652900a3f848cdd
Gerrit-Change-Number: 28465
Gerrit-PatchSet: 1
Gerrit-Owner: Subrata Banik <subrata.banik at intel.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180904/56d5fe87/attachment.html>