[coreboot-gerrit] Change in coreboot[master]: mb/google/poppy/variants/nautilus: Bump VCC_SA voltage offset 75mV

Seunghwan Kim (Code Review) gerrit at coreboot.org
Mon Sep 3 13:51:30 CEST 2018


Hello Marx Wang, build bot (Jenkins), Furquan Shaikh, 

I'd like you to reexamine a change. Please visit

    https://review.coreboot.org/28439

to look at the new patch set (#2).

Change subject: mb/google/poppy/variants/nautilus: Bump VCC_SA voltage offset 75mV
......................................................................

mb/google/poppy/variants/nautilus: Bump VCC_SA voltage offset 75mV

Nautilus-Wifi with m3 AP got a halt issue during CTS test.

Nautilus-Wifi was FCS with Celeron AP first and also its PCB/BOM was
validated only with Celeron. Since Celeron deos not support turbo
boost mode, its steady power demend and lower CPU frequency may not
reflect the potential noise hidden inside the board.

Bumping VCC_SA voltage offset 75mV confirmed works to mitigate the
potential noise coupling to VCC_GT/SA, and we verified this change
makes this issue go away on Nautilus-Wifi board.

Nautilus-LTE doesn't show this issue, since it has 10L PCB, will have
better grounding and less noise/ripple than 8L PCB.

BUG=b:111417632
BRANCH=poppy
TEST=Verified CTS test pass without an issue.

Change-Id: Id13fcc36a5b6ed42620c66f57a7303f30bff1a50
Signed-off-by: Seunghwan Kim <sh_.kim at samsung.com>
---
M src/mainboard/google/poppy/romstage.c
M src/mainboard/google/poppy/variants/baseboard/include/baseboard/variants.h
M src/mainboard/google/poppy/variants/nautilus/Makefile.inc
M src/mainboard/google/poppy/variants/nautilus/mainboard.c
M src/mainboard/google/poppy/variants/nautilus/memory.c
A src/mainboard/google/poppy/variants/nautilus/sku.c
6 files changed, 78 insertions(+), 21 deletions(-)


  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/39/28439/2
-- 
To view, visit https://review.coreboot.org/28439
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id13fcc36a5b6ed42620c66f57a7303f30bff1a50
Gerrit-Change-Number: 28439
Gerrit-PatchSet: 2
Gerrit-Owner: Seunghwan Kim <sh_.kim at samsung.com>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Marx Wang <marx.wang at intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180903/4bbe202a/attachment.html>


More information about the coreboot-gerrit mailing list