[coreboot-gerrit] Change in coreboot[master]: intel/fsp2_0: Add FSP NEXT shared stack feature support

build bot (Jenkins) (Code Review) gerrit at coreboot.org
Mon Sep 3 10:42:40 CEST 2018


build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/28358 )

Change subject: intel/fsp2_0: Add FSP NEXT shared stack feature support
......................................................................


Patch Set 8:

(1 comment)

https://review.coreboot.org/#/c/28358/8/src/drivers/intel/fsp2_0/memory_init.c
File src/drivers/intel/fsp2_0/memory_init.c:

https://review.coreboot.org/#/c/28358/8/src/drivers/intel/fsp2_0/memory_init.c@203
PS8, Line 203: 	if(setup_fsp_stack_frame(arch_upd, memmap))
space required before the open parenthesis '('



-- 
To view, visit https://review.coreboot.org/28358
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6581111dbaddfa403eca14100577ccc8a05c4ec7
Gerrit-Change-Number: 28358
Gerrit-PatchSet: 8
Gerrit-Owner: Aamir Bohra <aamir.bohra at intel.com>
Gerrit-Reviewer: Aamir Bohra <aamir.bohra at intel.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Hannah Williams <hannah.williams at intel.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Subrata Banik <subrata.banik at intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Reviewer: dhaval v sharma <dhaval.v.sharma at intel.com>
Gerrit-Comment-Date: Mon, 03 Sep 2018 08:42:40 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180903/c687ef6c/attachment.html>


More information about the coreboot-gerrit mailing list