[coreboot-gerrit] Change in coreboot[master]: mb/lenovo: Dual Graphics for xx20/xx30 ThinkPads

[Patrick Rudolph (Code Review)]

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/28393 )

Change subject: mb/lenovo: Dual Graphics for xx20/xx30 ThinkPads
......................................................................


Patch Set 7: Code-Review+1

(2 comments)

some nits

https://review.coreboot.org/#/c/28393/7/src/mainboard/lenovo/t430s/cmos.layout
File src/mainboard/lenovo/t430s/cmos.layout:

https://review.coreboot.org/#/c/28393/7/src/mainboard/lenovo/t430s/cmos.layout@79
PS7, Line 79: 435          1       e       13       enable_dual_graphics
1


https://review.coreboot.org/#/c/28393/7/src/mainboard/lenovo/t430s/cmos.layout@96
PS7, Line 96: 1     0     Disable
use enum 1 already in the list



-- 
To view, visit https://review.coreboot.org/28393
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8842fef0fa1235eb91abf6b7e655ed4d8598adc7
Gerrit-Change-Number: 28393
Gerrit-PatchSet: 7
Gerrit-Owner: Evgeny Zinoviev <me at ch1p.com>
Gerrit-Reviewer: Evgeny Zinoviev <me at ch1p.com>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Mon, 03 Sep 2018 05:56:36 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180903/3dfb294d/attachment.html>