[coreboot-gerrit] Change in coreboot[master]: intel/fsp2_0: automatically split FSP into fsp{t, m, s}.bin

[Alex Thiessen (Code Review)]

Alex Thiessen has posted comments on this change. ( https://review.coreboot.org/28385 )

Change subject: intel/fsp2_0: automatically split FSP into fsp{t,m,s}.bin
......................................................................


Patch Set 1:

(3 comments)

https://review.coreboot.org/#/c/28385/1//COMMIT_MSG
Commit Message:

https://review.coreboot.org/#/c/28385/1//COMMIT_MSG@9
PS1, Line 9: splited
split


https://review.coreboot.org/#/c/28385/1/src/drivers/intel/fsp2_0/Makefile.inc
File src/drivers/intel/fsp2_0/Makefile.inc:

https://review.coreboot.org/#/c/28385/1/src/drivers/intel/fsp2_0/Makefile.inc@23
PS1, Line 23: python
Better let the shebang decide. FYI, python2 is EOL in 16 months.


https://review.coreboot.org/#/c/28385/1/src/drivers/intel/fsp2_0/Makefile.inc@23
PS1, Line 23: $(info $(shell python ./util/fsptool/SplitFsp.py $(FAMILY)))
This will be executed every time even when nothing changes. Better define targets and a recipe, I guess.



-- 
To view, visit https://review.coreboot.org/28385
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic7b7ab6197e72ef06f90d4fc41d937cbb570bbbc
Gerrit-Change-Number: 28385
Gerrit-PatchSet: 1
Gerrit-Owner: Krystian Hebel (1002088)
Gerrit-Reviewer: Andrey Petrov <andrey.petrov at gmail.com>
Gerrit-Reviewer: Krystian Hebel (1002088)
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Alex Thiessen <alex.thiessen.de+coreboot at gmail.com>
Gerrit-Comment-Date: Sun, 02 Sep 2018 17:43:53 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180902/141160ba/attachment.html>