[coreboot-gerrit] Change in coreboot[master]: src/drivers/spi/tpm: Fix typo & capitalize TPM and IRQ

[Martin Roth (Code Review)]

Martin Roth has submitted this change and it was merged. ( https://review.coreboot.org/28387 )

Change subject: src/drivers/spi/tpm: Fix typo & capitalize TPM and IRQ
......................................................................

src/drivers/spi/tpm: Fix typo & capitalize TPM and IRQ

Change-Id: Ifb1e024821153865dd4a27a100f8a9c61151e0e1
Signed-off-by: Elyes HAOUAS <ehaouas at noos.fr>
Reviewed-on: https://review.coreboot.org/28387
Tested-by: build bot (Jenkins) <no-reply at coreboot.org>
Reviewed-by: Angel Pons <th3fanbus at gmail.com>
---
M src/drivers/spi/tpm/tpm.c
1 file changed, 9 insertions(+), 9 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Angel Pons: Looks good to me, approved



diff --git a/src/drivers/spi/tpm/tpm.c b/src/drivers/spi/tpm/tpm.c
index 3206ba1..bdd40a8 100644
--- a/src/drivers/spi/tpm/tpm.c
+++ b/src/drivers/spi/tpm/tpm.c
@@ -79,8 +79,8 @@
 }
 
 /*
- * TPM may trigger a irq after finish processing previous transfer.
- * Waiting for this irq to sync tpm status.
+ * TPM may trigger a IRQ after finish processing previous transfer.
+ * Waiting for this IRQ to sync TPM status.
  *
  * Returns 1 on success, 0 on failure (timeout).
  */
@@ -91,7 +91,7 @@
 	stopwatch_init_msecs_expire(&sw, 10);
 	while (!tis_plat_irq_status()) {
 		if (stopwatch_expired(&sw)) {
-			printk(BIOS_ERR, "Timeout wait for tpm irq!\n");
+			printk(BIOS_ERR, "Timeout wait for TPM IRQ!\n");
 			return 0;
 		}
 	}
@@ -119,7 +119,7 @@
 	 */
 	int wakeup_needed = 1;
 
-	/* Wait for tpm to finish previous transaction if needed */
+	/* Wait for TPM to finish previous transaction if needed */
 	if (car_get_var(tpm_sync_needed)) {
 		tpm_sync();
 		/*
@@ -430,7 +430,7 @@
 
 	memcpy(spi_slave, spi_if, sizeof(*spi_if));
 
-	/* clear any pending irqs */
+	/* clear any pending IRQs */
 	tis_plat_irq_status();
 
 	/*
@@ -442,12 +442,12 @@
 	for (retries = 15; retries > 0; retries--) {
 		int i;
 
-		/* In case of falure to read div_vid is set to zero. */
+		/* In case of failure to read div_vid is set to zero. */
 		tpm2_read_reg(TPM_DID_VID_REG, &did_vid, sizeof(did_vid));
 
 		for (i = 0; i < ARRAY_SIZE(supported_did_vids); i++)
 			if (did_vid == supported_did_vids[i])
-				break; /* Tpm is up and ready. */
+				break; /* TPM is up and ready. */
 
 		if (i < ARRAY_SIZE(supported_did_vids))
 			break;
@@ -643,7 +643,7 @@
 	write_tpm_sts(TPM_STS_COMMAND_READY);
 
 	/*
-	 * Tpm commands and responses written to and read from the FIFO
+	 * TPM commands and responses written to and read from the FIFO
 	 * register (0x24) are datagrams of variable size, prepended by a 6
 	 * byte header.
 	 *
@@ -687,7 +687,7 @@
 		 * TODO(vbendeb): at least drain the FIFO here or somehow let
 		 * the TPM know that the response can be dropped.
 		 */
-		printk(BIOS_ERR, " tpm response too long (%zd bytes)",
+		printk(BIOS_ERR, " TPM response too long (%zd bytes)",
 		       payload_size);
 		return 0;
 	}

-- 
To view, visit https://review.coreboot.org/28387
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifb1e024821153865dd4a27a100f8a9c61151e0e1
Gerrit-Change-Number: 28387
Gerrit-PatchSet: 3
Gerrit-Owner: Elyes HAOUAS <ehaouas at noos.fr>
Gerrit-Reviewer: Angel Pons <th3fanbus at gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180902/2f896255/attachment.html>