[coreboot-gerrit] Change in coreboot[master]: soc/intel/cannonlake: Enable ISH from device

[Lijian Zhao (Code Review)]

Lijian Zhao has posted comments on this change. ( https://review.coreboot.org/29274 )

Change subject: soc/intel/cannonlake: Enable ISH from device
......................................................................


Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/29274/1/src/soc/intel/cannonlake/romstage/fsp_params.c
File src/soc/intel/cannonlake/romstage/fsp_params.c:

https://review.coreboot.org/#/c/29274/1/src/soc/intel/cannonlake/romstage/fsp_params.c@59
PS1, Line 59: const struct device *dev = dev_find_slot(0, PCH_DEVFN_ISH);
> move this to the beginning of the function
Done



-- 
To view, visit https://review.coreboot.org/29274
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6889634bf65e7ce5cc3e3393c57c86d622f1ac68
Gerrit-Change-Number: 29274
Gerrit-PatchSet: 1
Gerrit-Owner: Lijian Zhao <lijian.zhao at intel.com>
Gerrit-Reviewer: Bora Guvendik <bora.guvendik at intel.com>
Gerrit-Reviewer: Hannah Williams <hannah.williams at intel.com>
Gerrit-Reviewer: Krzysztof M Sywula <krzysztof.m.sywula at intel.com>
Gerrit-Reviewer: Kyoung Il Kim <kyoung.il.kim at intel.com>
Gerrit-Reviewer: Li1 Feng <li1.feng at intel.com>
Gerrit-Reviewer: Lijian Zhao <lijian.zhao at intel.com>
Gerrit-Reviewer: Pratikkumar V Prajapati <pratikkumar.v.prajapati at intel.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik at intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Wed, 31 Oct 2018 18:01:20 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181031/76eedc04/attachment.html>