[coreboot-gerrit] Change in coreboot[master]: nb/intel/haswell: Add a PCI ID for a desktop memory controller

Tristan Corrick (Code Review) gerrit at coreboot.org
Wed Oct 31 15:18:37 CET 2018


Tristan Corrick has posted comments on this change. ( https://review.coreboot.org/29378 )

Change subject: nb/intel/haswell: Add a PCI ID for a desktop memory controller
......................................................................


Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/29378/1/src/northbridge/intel/haswell/northbridge.c
File src/northbridge/intel/haswell/northbridge.c:

https://review.coreboot.org/#/c/29378/1/src/northbridge/intel/haswell/northbridge.c@468
PS1, Line 468: };
> I guess you could alternatively combine all three `pci_driver`s […]
Okay. I've created a follow-on commit to this that combines them.



-- 
To view, visit https://review.coreboot.org/29378
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie162cb7a27e313ffe612659e8444657a3772d3c9
Gerrit-Change-Number: 29378
Gerrit-PatchSet: 1
Gerrit-Owner: Tristan Corrick <tristan at corrick.kiwi>
Gerrit-Reviewer: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: Tristan Corrick <tristan at corrick.kiwi>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Wed, 31 Oct 2018 14:18:37 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181031/22cbc774/attachment.html>


More information about the coreboot-gerrit mailing list