[coreboot-gerrit] Change in coreboot[master]: sb/intel/lynxpoint: Deduplicate `acpi_fill_madt()`

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/29388 )

Change subject: sb/intel/lynxpoint: Deduplicate `acpi_fill_madt()`
......................................................................


Patch Set 1: Code-Review+1

(2 comments)

https://review.coreboot.org/#/c/29388/1//COMMIT_MSG
Commit Message:

https://review.coreboot.org/#/c/29388/1//COMMIT_MSG@11
PS1, Line 11: copied from sb/intel/bd82x6x
Maybe sb/intel/common/ is a better place for the things you copied
from bd82x6x? Many things actually didn't change from ICH7 to PCH9
(Wildcat Point), so this might apply to many more systems.


https://review.coreboot.org/#/c/29388/1/src/southbridge/intel/lynxpoint/madt.c
File src/southbridge/intel/lynxpoint/madt.c:

https://review.coreboot.org/#/c/29388/1/src/southbridge/intel/lynxpoint/madt.c@16
PS1, Line 16: #include <types.h>
            : #include <string.h>
            : #include <cbmem.h>
            : #include <console/console.h>
            : #include <arch/acpi.h>
            : #include <arch/ioapic.h>
            : #include <arch/acpigen.h>
            : #include <arch/smp/mpspec.h>
That can't be all needed.



-- 
To view, visit https://review.coreboot.org/29388
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ife9e3917febf43d8a92cac66b502e2dee8527556
Gerrit-Change-Number: 29388
Gerrit-PatchSet: 1
Gerrit-Owner: Tristan Corrick <tristan at corrick.kiwi>
Gerrit-Reviewer: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Wed, 31 Oct 2018 13:53:47 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181031/24a7976a/attachment.html>