[coreboot-gerrit] Change in coreboot[master]: soc/amd/stoneyridge: Fix get_cpu_count()

Martin Roth (Code Review) gerrit at coreboot.org
Wed Oct 31 05:37:39 CET 2018


Martin Roth has uploaded this change for review. ( https://review.coreboot.org/29367


Change subject: soc/amd/stoneyridge: Fix get_cpu_count()
......................................................................

soc/amd/stoneyridge: Fix get_cpu_count()

In commit 41baf0c3ff (soc/amd/stoneyridge: Remove dev_find_slot where
possible), the register being read was changed accidentally from
HT_DEV (Device 18h, Func 0) to NB_DEV (Device 18h, Func 5)

This doesn't return the correct value, and causes Grunt to reboot.

BUG=b:118721473
TEST=Boot grunt

Change-Id: I7b73358a074dd27639aafead7c8b39f0fad5685f
Signed-off-by: Martin Roth <martinroth at google.com>
---
M src/soc/amd/stoneyridge/cpu.c
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/67/29367/1

diff --git a/src/soc/amd/stoneyridge/cpu.c b/src/soc/amd/stoneyridge/cpu.c
index 6cb59a9..1d9804d 100644
--- a/src/soc/amd/stoneyridge/cpu.c
+++ b/src/soc/amd/stoneyridge/cpu.c
@@ -55,7 +55,7 @@
 
 static int get_cpu_count(void)
 {
-	return (pci_read_config16(SOC_NB_DEV, D18F0_CPU_CNT) & CPU_CNT_MASK)
+	return (pci_read_config16(SOC_HT_DEV, D18F0_CPU_CNT) & CPU_CNT_MASK)
 									+ 1;
 }
 

-- 
To view, visit https://review.coreboot.org/29367
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7b73358a074dd27639aafead7c8b39f0fad5685f
Gerrit-Change-Number: 29367
Gerrit-PatchSet: 1
Gerrit-Owner: Martin Roth <martinroth at google.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181031/af8a9c50/attachment.html>


More information about the coreboot-gerrit mailing list