[coreboot-gerrit] Change in coreboot[master]: soc/intel/apollolake: Improve cold boot and S3 resume

build bot (Jenkins) (Code Review) gerrit at coreboot.org
Tue Oct 30 23:39:32 CET 2018


build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/29363 )

Change subject: soc/intel/apollolake: Improve cold boot and S3 resume
......................................................................


Patch Set 1:

(2 comments)

https://review.coreboot.org/#/c/29363/1/src/soc/intel/apollolake/chip.c
File src/soc/intel/apollolake/chip.c:

https://review.coreboot.org/#/c/29363/1/src/soc/intel/apollolake/chip.c@572
PS1, Line 572: 	 * FSP provides UPD interface to execute IPC command. In order to improve boot
line over 80 characters


https://review.coreboot.org/#/c/29363/1/src/soc/intel/apollolake/chip.c@573
PS1, Line 573: 	 * performance, configure PmicPmcIpcCtrl for PMC to program PMIC PCH_PWROK delay
line over 80 characters



-- 
To view, visit https://review.coreboot.org/29363
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I05656c9083a855112120b7f1b0ec01c42f582409
Gerrit-Change-Number: 29363
Gerrit-PatchSet: 1
Gerrit-Owner: John Zhao <john.zhao at intel.com>
Gerrit-CC: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Tue, 30 Oct 2018 22:39:32 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181030/fd26ab08/attachment.html>


More information about the coreboot-gerrit mailing list