[coreboot-gerrit] Change in coreboot[master]: drivers/elog: Add support for early elog

[build bot (Jenkins) (Code Review)]

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/29358 )

Change subject: drivers/elog: Add support for early elog
......................................................................


Patch Set 1:

(4 comments)

https://review.coreboot.org/#/c/29358/1/src/drivers/elog/elog.c
File src/drivers/elog/elog.c:

https://review.coreboot.org/#/c/29358/1/src/drivers/elog/elog.c@75
PS1, Line 75: static uint8_t * get_elog_mirror_buffer(size_t elog_size) {
"foo * bar" should be "foo *bar"


https://review.coreboot.org/#/c/29358/1/src/drivers/elog/elog.c@75
PS1, Line 75: static uint8_t * get_elog_mirror_buffer(size_t elog_size) {
open brace '{' following function definitions go on the next line


https://review.coreboot.org/#/c/29358/1/src/drivers/elog/elog.c@90
PS1, Line 90: static uint8_t * get_elog_mirror_buffer(size_t elog_size) {
"foo * bar" should be "foo *bar"


https://review.coreboot.org/#/c/29358/1/src/drivers/elog/elog.c@90
PS1, Line 90: static uint8_t * get_elog_mirror_buffer(size_t elog_size) {
open brace '{' following function definitions go on the next line



-- 
To view, visit https://review.coreboot.org/29358
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia69515961da3bc72740f9b048a53d91af79c5b0d
Gerrit-Change-Number: 29358
Gerrit-PatchSet: 1
Gerrit-Owner: Karthik Ramasubramanian <kramasub at google.com>
Gerrit-Reviewer: Karthikeyan Ramasubramanian <kramasub at chromium.org>
Gerrit-CC: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Tue, 30 Oct 2018 16:04:25 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181030/94e8c905/attachment.html>