[coreboot-gerrit] Change in coreboot[master]: soc/amd/stoneyridge: Get rid of domain_read_resources

[Martin Roth (Code Review)]

Martin Roth has posted comments on this change. ( https://review.coreboot.org/29345 )

Change subject: soc/amd/stoneyridge: Get rid of domain_read_resources
......................................................................


Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/29345/1//COMMIT_MSG
Commit Message:

https://review.coreboot.org/#/c/29345/1//COMMIT_MSG@24
PS1, Line 24: the empty resource
> The particular empty resource was filled later:

It's NOT filled in later.  Look at a current boot log. You'll see these that you're talking about:

 Show resources in subtree (Root Device)...After assigning values.
...
  DOMAIN: 0000 resource base 1000 size 100 align 8 gran 0 limit ffff flags 40040100 index 10000000
  DOMAIN: 0000 resource base f0000000 size 4d8a100 align 26 gran 0 limit f7ffffff flags 40040200 index 0
...
  PCI: 00:18.0 resource base 0 size 0 align 0 gran 0 limit 0 flags 1 index 1080

That last entry is what I'm talking about.  Note that the index between these is different, so they're not the same resource node.

>Have you check if it's still being created? Or if not being created, does it affects the boot process anyway (it might be created and never used)?


No, it's not being created any more, that's the point of this patch.  Since it wasn't being filled in, it wasn't being used, and it should be deleted.

Yes, I've tested booting.  That's how I verified that only the empty resource changed.



-- 
To view, visit https://review.coreboot.org/29345
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I83bd3ea8db141416632c12fc883386070363f2f1
Gerrit-Change-Number: 29345
Gerrit-PatchSet: 1
Gerrit-Owner: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Daniel Kurtz <djkurtz at google.com>
Gerrit-Reviewer: Marc Jones <marc at marcjonesconsulting.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd at gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Raul Rangel <rrangel at chromium.org>
Gerrit-Reviewer: Richard Spiegel <richard.spiegel at silverbackltd.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Tue, 30 Oct 2018 15:29:31 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181030/37c38f8c/attachment.html>