[coreboot-gerrit] Change in coreboot[master]: soc/intel/cannonlake: Add additional UPD

[Philipp Deppenwiese (Code Review)]

Philipp Deppenwiese has posted comments on this change. ( https://review.coreboot.org/29324 )

Change subject: soc/intel/cannonlake: Add additional UPD
......................................................................


Patch Set 3:

(3 comments)

https://review.coreboot.org/#/c/29324/3/src/soc/intel/cannonlake/Kconfig
File src/soc/intel/cannonlake/Kconfig:

https://review.coreboot.org/#/c/29324/3/src/soc/intel/cannonlake/Kconfig@266
PS3, Line 266: 	bool "Use Clean Memory"
> Let FSP clean memory
Done


https://review.coreboot.org/#/c/29324/3/src/soc/intel/cannonlake/Kconfig@268
PS3, Line 268: 	  Ask MRC to clear memory content.
> Elaborate a little? Is clean and clear the same?
This is the description of the Intel documentation. IDK


https://review.coreboot.org/#/c/29324/3/src/soc/intel/cannonlake/romstage/fsp_params.c
File src/soc/intel/cannonlake/romstage/fsp_params.c:

https://review.coreboot.org/#/c/29324/3/src/soc/intel/cannonlake/romstage/fsp_params.c@59
PS3, Line 59: 	if (IS_ENABLED(CONFIG_USE_CANNONLAKE_CLEAN_MEMORY))
            : 		m_cfg->CleanMemory = 1;
            : 	else
            : 		m_cfg->CleanMemory = 0;
> Use ternary operator? […]
Nope. Harder to read and not better code



-- 
To view, visit https://review.coreboot.org/29324
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iddd2ffac59561941319563d1bbc45c542f99da27
Gerrit-Change-Number: 29324
Gerrit-PatchSet: 3
Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki at gmail.com>
Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph at 9elements.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki at gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Tue, 30 Oct 2018 12:20:49 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181030/08231dd6/attachment.html>