[coreboot-gerrit] Change in coreboot[master]: mb/lenovo/t430: Set USB always on when calling SMI sleep
Philipp Deppenwiese (Code Review)
gerrit at coreboot.org
Mon Oct 29 12:26:39 CET 2018
Philipp Deppenwiese has submitted this change and it was merged. ( https://review.coreboot.org/29031 )
Change subject: mb/lenovo/t430: Set USB always on when calling SMI sleep
......................................................................
mb/lenovo/t430: Set USB always on when calling SMI sleep
Looks like we must do it in the same way as in l520, t420, t420s,
t430s, t520, t530, x201, x220, x230 models. No idea why t430 should be
handled differently.
Change-Id: Ic4851022267caca267b667b4e3c327838e0a0b66
Signed-off-by: Peter Lemenkov <lemenkov at gmail.com>
Reviewed-on: https://review.coreboot.org/29031
Reviewed-by: Patrick Rudolph <siro at das-labor.org>
Tested-by: build bot (Jenkins) <no-reply at coreboot.org>
---
M src/mainboard/lenovo/t430/smihandler.c
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
build bot (Jenkins): Verified
Patrick Rudolph: Looks good to me, approved
diff --git a/src/mainboard/lenovo/t430/smihandler.c b/src/mainboard/lenovo/t430/smihandler.c
index 286f07a..910fc1a 100644
--- a/src/mainboard/lenovo/t430/smihandler.c
+++ b/src/mainboard/lenovo/t430/smihandler.c
@@ -72,9 +72,9 @@
void mainboard_smi_sleep(u8 slp_typ)
{
- if (slp_typ == 3) {
- h8_usb_always_on();
+ h8_usb_always_on();
+ if (slp_typ == 3) {
u8 ec_wake = ec_read(0x32);
/* If EC wake events are enabled, enable wake on EC WAKE GPE. */
if (ec_wake & 0x14) {
--
To view, visit https://review.coreboot.org/29031
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic4851022267caca267b667b4e3c327838e0a0b66
Gerrit-Change-Number: 29031
Gerrit-PatchSet: 3
Gerrit-Owner: Peter Lemenkov <lemenkov at gmail.com>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki at gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181029/b0459748/attachment.html>
More information about the coreboot-gerrit
mailing list