[coreboot-gerrit] Change in coreboot[master]: src/drivers/intel/fsp1_1/raminit.c: Missing NON_VOLATILE_STORAGE_HOB ...

Frans Hendriks (Code Review) gerrit at coreboot.org
Mon Oct 29 10:18:04 CET 2018


Frans Hendriks has uploaded this change for review. ( https://review.coreboot.org/29320


Change subject: src/drivers/intel/fsp1_1/raminit.c: Missing NON_VOLATILE_STORAGE_HOB is not an error
......................................................................

src/drivers/intel/fsp1_1/raminit.c: Missing NON_VOLATILE_STORAGE_HOB is not an error

The missing 7.3 NON_VOLATILE_STORAGE_HOB is reported as error.
Change the argument used in printk() to BIOS_DEBUG for this hob.

BUG=N/A
TEST=Intel CherryHill CRB

Change-Id: Ice8220149c2e44bb2da010d5a7d8bc4dbeca11e0
Signed-off-by: Frans Hendriks <fhendriks at eltan.com>
---
M src/drivers/intel/fsp1_1/raminit.c
1 file changed, 2 insertions(+), 1 deletion(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/20/29320/1

diff --git a/src/drivers/intel/fsp1_1/raminit.c b/src/drivers/intel/fsp1_1/raminit.c
index c7d8722..34bcf0b 100644
--- a/src/drivers/intel/fsp1_1/raminit.c
+++ b/src/drivers/intel/fsp1_1/raminit.c
@@ -2,6 +2,7 @@
  * This file is part of the coreboot project.
  *
  * Copyright (C) 2014-2016 Intel Corporation
+ * Copyright (C) 2018 Eltan B.V.
  *
  * This program is free software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by
@@ -217,7 +218,7 @@
 	}
 	hob_ptr.Raw = get_next_guid_hob(&mrc_guid, hob_list_ptr);
 	if (hob_ptr.Raw == NULL) {
-		printk(BIOS_ERR, "7.3: FSP_NON_VOLATILE_STORAGE_HOB missing!\n");
+		printk(BIOS_DEBUG, "7.3: FSP_NON_VOLATILE_STORAGE_HOB missing!\n");
 		fsp_verification_failure =
 			(params->pei_data->saved_data == NULL) ? 1 : 0;
 	} else {

-- 
To view, visit https://review.coreboot.org/29320
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ice8220149c2e44bb2da010d5a7d8bc4dbeca11e0
Gerrit-Change-Number: 29320
Gerrit-PatchSet: 1
Gerrit-Owner: Frans Hendriks <fhendriks at eltan.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181029/6395a319/attachment.html>


More information about the coreboot-gerrit mailing list