[coreboot-gerrit] Change in coreboot[master]: soc/intel/icelake: Allow coreboot to reserve stack for fsp

Aamir Bohra (Code Review) gerrit at coreboot.org
Mon Oct 29 09:10:50 CET 2018


Hello Subrata Banik,

I'd like you to do a code review. Please visit

    https://review.coreboot.org/29317

to review the following change.


Change subject: soc/intel/icelake: Allow coreboot to reserve stack for fsp
......................................................................

soc/intel/icelake: Allow coreboot to reserve stack for fsp

Change-Id: I5f2d9548b8e2c7b1d154b7bad126ec7b1052231a
Signed-off-by: Subrata Banik <subrata.banik at intel.com>
Signed-off-by: Aamir Bohra <aamir.bohra at intel.com>
---
M src/soc/intel/icelake/Kconfig
1 file changed, 2 insertions(+), 0 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/17/29317/1

diff --git a/src/soc/intel/icelake/Kconfig b/src/soc/intel/icelake/Kconfig
index 664add2..c4ee841 100644
--- a/src/soc/intel/icelake/Kconfig
+++ b/src/soc/intel/icelake/Kconfig
@@ -19,6 +19,7 @@
 	select CACHE_RELOCATED_RAMSTAGE_OUTSIDE_CBMEM
 	select COMMON_FADT
 	select CPU_INTEL_FIRMWARE_INTERFACE_TABLE
+	select FSP_USES_CB_STACK
 	select GENERIC_GPIO_LIB
 	select HAVE_FSP_GOP
 	select INTEL_DESCRIPTOR_MODE_CAPABLE
@@ -89,6 +90,7 @@
 
 config DCACHE_BSP_STACK_SIZE
 	hex
+	default 0x20000 if FSP_USES_CB_STACK
 	default 0x4000
 	help
 	  The amount of anticipated stack usage in CAR by bootblock and

-- 
To view, visit https://review.coreboot.org/29317
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5f2d9548b8e2c7b1d154b7bad126ec7b1052231a
Gerrit-Change-Number: 29317
Gerrit-PatchSet: 1
Gerrit-Owner: Aamir Bohra <aamir.bohra at intel.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik at intel.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181029/33673416/attachment-0001.html>


More information about the coreboot-gerrit mailing list