[coreboot-gerrit] Change in coreboot[master]: src: Remove unneeded include <arch/io.h>

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/29307 )

Change subject: src: Remove unneeded include <arch/io.h>
......................................................................


Patch Set 13:

>>> I'm getting some errors. some of them looks "odd" to me:
>>
>> Looks like the errors to expect when an #include is missing. How
>> did
>> you detect which files don't require the #include?
>>
>> Some of the errors look like they are actually about missing
>> #includes
>> in other places that were hidden because of #includes you remove
>> here.
> 
> it was my mistake ...
> if I remove an "include io.h" for exmple from "src/southbridge/amd/cs5536/cs5536.c",
> the compiler will complain about unknown type here : "cpu/amd/vr.h"

That's not your mistake then. It means `cpu/amd/vr.h` is missing
an #include (it just wasn't visible before).

The same can happen if you remove #includes and just test if it
compiles (some other included file can hide the problem). That's
why I ask again: How do you decide which #include statements are
unneeded? Did you use some static analysis tool? did you read
all the code?


-- 
To view, visit https://review.coreboot.org/29307
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia18c77876121594a272a07d56acfaa863d0ccb25
Gerrit-Change-Number: 29307
Gerrit-PatchSet: 13
Gerrit-Owner: Elyes HAOUAS <ehaouas at noos.fr>
Gerrit-Reviewer: Elyes HAOUAS <ehaouas at noos.fr>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Nico Huber <nico.h at gmx.de>
Gerrit-Comment-Date: Sun, 28 Oct 2018 13:31:24 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181028/de6775b5/attachment.html>