[coreboot-gerrit] Change in coreboot[master]: src: Remove unneeded include <arch/io.h>
Elyes HAOUAS (Code Review)
gerrit at coreboot.org
Sun Oct 28 14:26:28 CET 2018
Elyes HAOUAS has posted comments on this change. ( https://review.coreboot.org/29307 )
Change subject: src: Remove unneeded include <arch/io.h>
......................................................................
Patch Set 13:
> > I'm getting some errors. some of them looks "odd" to me:
>
> Looks like the errors to expect when an #include is missing. How
> did
> you detect which files don't require the #include?
>
> Some of the errors look like they are actually about missing
> #includes
> in other places that were hidden because of #includes you remove
> here.
it was my mistake ...
if I remove an "include io.h" for exmple from "src/southbridge/amd/cs5536/cs5536.c", the compiler will complain about unknown type here : "cpu/amd/vr.h"
--
To view, visit https://review.coreboot.org/29307
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia18c77876121594a272a07d56acfaa863d0ccb25
Gerrit-Change-Number: 29307
Gerrit-PatchSet: 13
Gerrit-Owner: Elyes HAOUAS <ehaouas at noos.fr>
Gerrit-Reviewer: Elyes HAOUAS <ehaouas at noos.fr>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Nico Huber <nico.h at gmx.de>
Gerrit-Comment-Date: Sun, 28 Oct 2018 13:26:28 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181028/e74a6c3d/attachment.html>
More information about the coreboot-gerrit
mailing list