[coreboot-gerrit] Change in coreboot[master]: soc/intel/*: Make FSP header path user configurable

Philipp Deppenwiese (Code Review) gerrit at coreboot.org
Sun Oct 28 01:58:18 CEST 2018


Philipp Deppenwiese has submitted this change and it was merged. ( https://review.coreboot.org/29293 )

Change subject: soc/intel/*: Make FSP header path user configurable
......................................................................

soc/intel/*: Make FSP header path user configurable

Required to compensate for Chrome OS' tree differences

Change-Id: I01fe80b55c69ff57da1c96a76bd1d9b5a2d4a9a8
Signed-off-by: Patrick Georgi <pgeorgi at google.com>
Reviewed-on: https://review.coreboot.org/29293
Tested-by: build bot (Jenkins) <no-reply at coreboot.org>
Reviewed-by: Philipp Deppenwiese <zaolin.daisuki at gmail.com>
---
M src/soc/intel/apollolake/Kconfig
M src/soc/intel/cannonlake/Kconfig
M src/soc/intel/icelake/Kconfig
M src/soc/intel/skylake/Kconfig
4 files changed, 4 insertions(+), 4 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Philipp Deppenwiese: Looks good to me, approved



diff --git a/src/soc/intel/apollolake/Kconfig b/src/soc/intel/apollolake/Kconfig
index 59cc31f..0c0fca9 100644
--- a/src/soc/intel/apollolake/Kconfig
+++ b/src/soc/intel/apollolake/Kconfig
@@ -201,7 +201,7 @@
 	  The base address (in CAR) where verstage should be linked
 
 config FSP_HEADER_PATH
-	string
+	string "Location of FSP headers"
 	default "src/vendorcode/intel/fsp/fsp2_0/glk" if SOC_INTEL_GLK
 	default "3rdparty/fsp/ApolloLakeFspBinPkg/Include/"
 
diff --git a/src/soc/intel/cannonlake/Kconfig b/src/soc/intel/cannonlake/Kconfig
index 161db33..9452b6d 100644
--- a/src/soc/intel/cannonlake/Kconfig
+++ b/src/soc/intel/cannonlake/Kconfig
@@ -264,7 +264,7 @@
 endchoice
 
 config FSP_HEADER_PATH
-	string
+	string "Location of FSP headers"
 	default "src/vendorcode/intel/fsp/fsp2_0/cannonlake/" if !SOC_INTEL_COFFEELAKE
 	default "3rdparty/fsp/CoffeeLakeFspBinPkg/Include/" if SOC_INTEL_COFFEELAKE
 
diff --git a/src/soc/intel/icelake/Kconfig b/src/soc/intel/icelake/Kconfig
index bc13f4f..664add2 100644
--- a/src/soc/intel/icelake/Kconfig
+++ b/src/soc/intel/icelake/Kconfig
@@ -200,7 +200,7 @@
 endchoice
 
 config FSP_HEADER_PATH
-	string
+	string "Location of FSP headers"
 	default "src/vendorcode/intel/fsp/fsp2_0/icelake/"
 
 config FSP_FD_PATH
diff --git a/src/soc/intel/skylake/Kconfig b/src/soc/intel/skylake/Kconfig
index 3f146a0..1449d3d 100644
--- a/src/soc/intel/skylake/Kconfig
+++ b/src/soc/intel/skylake/Kconfig
@@ -303,7 +303,7 @@
 endchoice
 
 config FSP_HEADER_PATH
-	string
+	string "Location of FSP headers"
 	depends on MAINBOARD_USES_FSP2_0
 	# Use KabylakeFsp for both Skylake and Kabylake as it supports both.
 	# SkylakeFsp is FSP 1.1 and therefore incompatible.

-- 
To view, visit https://review.coreboot.org/29293
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I01fe80b55c69ff57da1c96a76bd1d9b5a2d4a9a8
Gerrit-Change-Number: 29293
Gerrit-PatchSet: 2
Gerrit-Owner: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki at gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181027/f009aaf2/attachment.html>


More information about the coreboot-gerrit mailing list