[coreboot-gerrit] Change in coreboot[master]: mainboard/google/kahlee: Setting PSPP to BalanceHigh

Akshu Agrawal (Code Review) gerrit at coreboot.org
Fri Oct 26 08:32:37 CEST 2018


Akshu Agrawal has uploaded this change for review. ( https://review.coreboot.org/29282


Change subject: mainboard/google/kahlee: Setting PSPP to BalanceHigh
......................................................................

mainboard/google/kahlee: Setting PSPP to BalanceHigh

Without IOMMU and PsppBalanceLow audio does not work
and dma from sysmem to ACP sram gets stuck.
We cannot have IOMMU enabled for ST as it causes a siginificant
impact to performance and also can cause potential problems with ACP
as ACP IP uses fixed address offset.
Hence, setting to PsppBalanceHigh.

BUG=b:116553085
TEST=Playback audio

Change-Id: Ia7de98184063f5e52e52ac08f2b5d6446acdcb59
Signed-off-by: Akshu Agrawal <akshu.agrawal at amd.com>
---
M src/mainboard/google/kahlee/variants/baseboard/OemCustomize.c
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/82/29282/1

diff --git a/src/mainboard/google/kahlee/variants/baseboard/OemCustomize.c b/src/mainboard/google/kahlee/variants/baseboard/OemCustomize.c
index 42d9a49..11d75f2 100644
--- a/src/mainboard/google/kahlee/variants/baseboard/OemCustomize.c
+++ b/src/mainboard/google/kahlee/variants/baseboard/OemCustomize.c
@@ -149,7 +149,7 @@
 VOID __weak OemCustomizeInitEarly(IN OUT AMD_EARLY_PARAMS *InitEarly)
 {
 	InitEarly->GnbConfig.PcieComplexList = (void *)&PcieComplex;
-	InitEarly->GnbConfig.PsppPolicy = PsppBalanceLow;
+	InitEarly->GnbConfig.PsppPolicy = PsppBalanceHigh;
 	InitEarly->PlatformConfig.GnbAzI2sBusSelect = GnbAcpI2sBus;
 	InitEarly->PlatformConfig.GnbAzI2sBusPinConfig = GnbAcp2Tx4RxBluetooth;
 }

-- 
To view, visit https://review.coreboot.org/29282
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia7de98184063f5e52e52ac08f2b5d6446acdcb59
Gerrit-Change-Number: 29282
Gerrit-PatchSet: 1
Gerrit-Owner: Akshu Agrawal <akshu.agrawal at amd.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181026/123bac31/attachment.html>


More information about the coreboot-gerrit mailing list