[coreboot-gerrit] Change in coreboot[master]: soc/amd/stoneyridge: SMBUS access through MMIO

[build bot (Jenkins) (Code Review)]

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/29256 )

Change subject: soc/amd/stoneyridge: SMBUS access through MMIO
......................................................................


Patch Set 1:

(2 comments)

https://review.coreboot.org/#/c/29256/1/src/soc/amd/stoneyridge/include/soc/smbus.h
File src/soc/amd/stoneyridge/include/soc/smbus.h:

https://review.coreboot.org/#/c/29256/1/src/soc/amd/stoneyridge/include/soc/smbus.h@23
PS1, Line 23: 	#define SMB_RD(base, reg)	 read8((void*)SMBUS_MMIO_BASE + reg)
"(foo*)" should be "(foo *)"


https://review.coreboot.org/#/c/29256/1/src/soc/amd/stoneyridge/include/soc/smbus.h@24
PS1, Line 24: 	#define SMB_WR(value, base, reg) write8((void*)SMBUS_MMIO_BASE + reg, \
"(foo*)" should be "(foo *)"



-- 
To view, visit https://review.coreboot.org/29256
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1bdfadea128a460422b7e09f119cada691bad34a
Gerrit-Change-Number: 29256
Gerrit-PatchSet: 1
Gerrit-Owner: Richard Spiegel <richard.spiegel at silverbackltd.com>
Gerrit-CC: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Wed, 24 Oct 2018 19:49:27 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181024/86da651d/attachment.html>