[coreboot-gerrit] Change in coreboot[master]: {cpu, drivers, nb, sb}/amd: Replace {MSR, MTRR} addresses with macros

build bot (Jenkins) (Code Review) gerrit at coreboot.org
Wed Oct 24 16:29:40 CEST 2018


build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/29243 )

Change subject: {cpu,drivers,nb,sb}/amd: Replace {MSR,MTRR} addresses with macros
......................................................................


Patch Set 8:

(2 comments)

https://review.coreboot.org/#/c/29243/8/src/northbridge/amd/amdmct/mct_ddr3/s3utils.c
File src/northbridge/amd/amdmct/mct_ddr3/s3utils.c:

https://review.coreboot.org/#/c/29243/8/src/northbridge/amd/amdmct/mct_ddr3/s3utils.c@364
PS8, Line 364: 				data->msr0000020[i] = rdmsr_uint64_t(MTRR_PHYS_BASE(0) | i);
line over 80 characters


https://review.coreboot.org/#/c/29243/8/src/northbridge/amd/amdmct/mct_ddr3/s3utils.c@703
PS8, Line 703: 				wrmsr_uint64_t(MTRR_PHYS_BASE(0) | i, data->msr0000020[i]);
line over 80 characters



-- 
To view, visit https://review.coreboot.org/29243
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7e8de35dcdad52bb311b34bfa9b272d17ed3186b
Gerrit-Change-Number: 29243
Gerrit-PatchSet: 8
Gerrit-Owner: Elyes HAOUAS <ehaouas at noos.fr>
Gerrit-Reviewer: Elyes HAOUAS <ehaouas at noos.fr>
Gerrit-Reviewer: Richard Spiegel <richard.spiegel at silverbackltd.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Martin Roth <martinroth at google.com>
Gerrit-Comment-Date: Wed, 24 Oct 2018 14:29:40 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181024/275391d7/attachment.html>


More information about the coreboot-gerrit mailing list