[coreboot-gerrit] Change in coreboot[master]: arch/x86/acpi: Add TPM2 table support
build bot (Jenkins) (Code Review)
gerrit at coreboot.org
Wed Oct 24 11:12:50 CEST 2018
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/29181 )
Change subject: arch/x86/acpi: Add TPM2 table support
......................................................................
Patch Set 7:
(2 comments)
https://review.coreboot.org/#/c/29181/7/src/arch/x86/acpi.c
File src/arch/x86/acpi.c:
https://review.coreboot.org/#/c/29181/7/src/arch/x86/acpi.c@326
PS7, Line 326: tpm2->platform_class = 0; // Hard to detect for coreboot. Just set it to 0
line over 80 characters
https://review.coreboot.org/#/c/29181/7/src/arch/x86/acpi.c@328
PS7, Line 328: tpm2->start_method = 6; // coreboot only supports the TIS interface driver
line over 80 characters
--
To view, visit https://review.coreboot.org/29181
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I030c7ea744bcfe61ebef8d66d1295273b5dccda5
Gerrit-Change-Number: 29181
Gerrit-PatchSet: 7
Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki at gmail.com>
Gerrit-Reviewer: Joel Kitching <kitching at google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph at 9elements.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Vadim Bendebury <vbendeb at chromium.org>
Gerrit-Reviewer: Werner Zeh <werner.zeh at siemens.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Patrick Rudolph (1001864)
Gerrit-Comment-Date: Wed, 24 Oct 2018 09:12:50 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181024/a51abd67/attachment.html>
More information about the coreboot-gerrit
mailing list