[coreboot-gerrit] Change in coreboot[master]: soc/amd/stoneyridge: Replace public magic numbers

build bot (Jenkins) (Code Review) gerrit at coreboot.org
Tue Oct 23 17:10:10 CEST 2018


build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/29198 )

Change subject: soc/amd/stoneyridge: Replace public magic numbers
......................................................................


Patch Set 5:

(1 comment)

https://review.coreboot.org/#/c/29198/5/src/soc/amd/stoneyridge/northbridge.c
File src/soc/amd/stoneyridge/northbridge.c:

https://review.coreboot.org/#/c/29198/5/src/soc/amd/stoneyridge/northbridge.c@405
PS5, Line 405: 		if (base & (MMIO_WE) | MMIO_RE)) {
trailing statements should be on next line



-- 
To view, visit https://review.coreboot.org/29198
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I96ac59fd92c4a5e27c3836f77bf6633e9b0c4990
Gerrit-Change-Number: 29198
Gerrit-PatchSet: 5
Gerrit-Owner: Richard Spiegel <richard.spiegel at silverbackltd.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd at gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Richard Spiegel <richard.spiegel at silverbackltd.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Tue, 23 Oct 2018 15:10:10 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181023/04817073/attachment.html>


More information about the coreboot-gerrit mailing list