[coreboot-gerrit] Change in coreboot[master]: src: Variable name annotation shouldn't contain asterisks

build bot (Jenkins) (Code Review) gerrit at coreboot.org
Tue Oct 23 13:53:27 CEST 2018


build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/29235 )

Change subject: src: Variable name annotation shouldn't contain asterisks
......................................................................


Patch Set 5:

(19 comments)

https://review.coreboot.org/#/c/29235/5/src/northbridge/amd/amdht/h3finit.h
File src/northbridge/amd/amdht/h3finit.h:

https://review.coreboot.org/#/c/29235/5/src/northbridge/amd/amdht/h3finit.h@229
PS5, Line 229: 	 *	@param[in,out] u8  LinkWidthIn  = modify to change the Link Witdh In
line over 80 characters


https://review.coreboot.org/#/c/29235/5/src/northbridge/amd/amdht/h3finit.h@230
PS5, Line 230: 	 *	@param[in,out] u8  LinkWidthOut = modify to change the Link Witdh Out
line over 80 characters


https://review.coreboot.org/#/c/29235/5/src/northbridge/amd/amdht/h3finit.h@231
PS5, Line 231: 	 *	@param[in,out] u32 FreqCap      = modify to change the link's frequency capability
line over 80 characters


https://review.coreboot.org/#/c/29235/5/src/northbridge/amd/amdht/h3finit.h@232
PS5, Line 232: 	 *	@param[in,out] u32 FeatureCap   = modify to change the link's feature capability
line over 80 characters


https://review.coreboot.org/#/c/29235/5/src/northbridge/amd/amdht/h3finit.h@269
PS5, Line 269: 	 *	@param[in,out]  u8  ABLinkWidthLimit = modify to change the Link Witdh In
line over 80 characters


https://review.coreboot.org/#/c/29235/5/src/northbridge/amd/amdht/h3finit.h@270
PS5, Line 270: 	 *	@param[in,out]  u8  BALinkWidthLimit = modify to change the Link Witdh Out
line over 80 characters


https://review.coreboot.org/#/c/29235/5/src/northbridge/amd/amdht/h3finit.h@271
PS5, Line 271: 	 *	@param[in,out]  u32 PCBFreqCap = modify to change the link's frequency capability
line over 80 characters


https://review.coreboot.org/#/c/29235/5/src/northbridge/amd/amdht/h3finit.h@302
PS5, Line 302: 	 *	@param[in,out]  u8  DownstreamLinkWidthLimit = modify to change the Link Witdh In
line over 80 characters


https://review.coreboot.org/#/c/29235/5/src/northbridge/amd/amdht/h3finit.h@303
PS5, Line 303: 	 *	@param[in,out]  u8  UpstreamLinkWidthLimit  = modify to change the Link Witdh Out
line over 80 characters


https://review.coreboot.org/#/c/29235/5/src/northbridge/amd/amdht/h3finit.h@304
PS5, Line 304: 	 *	@param[in,out]  u32 PCBFreqCap = modify to change the link's frequency capability
line over 80 characters


https://review.coreboot.org/#/c/29235/5/src/northbridge/amd/amdht/h3finit.h@403
PS5, Line 403: 	 *	@param[in,out]  u8  LinkWidthIn   = modify to change the Link Witdh In
line over 80 characters


https://review.coreboot.org/#/c/29235/5/src/northbridge/amd/amdht/h3finit.h@404
PS5, Line 404: 	 *	@param[in,out]  u8  LinkWidthOut  = modify to change the Link Witdh Out
line over 80 characters


https://review.coreboot.org/#/c/29235/5/src/northbridge/amd/amdht/h3finit.h@405
PS5, Line 405: 	 *	@param[in,out]  u16 LinkFrequency = modify to change the link's frequency capability
line over 80 characters


https://review.coreboot.org/#/c/29235/5/src/northbridge/amd/amdht/h3finit.h@434
PS5, Line 434: 	 *	@param[in,out]  u8  LinkWidthIn = modify to change the Link Witdh In
line over 80 characters


https://review.coreboot.org/#/c/29235/5/src/northbridge/amd/amdht/h3finit.h@435
PS5, Line 435: 	 *	@param[in,out]  u8  LinkWidthOut = modify to change the Link Witdh Out
line over 80 characters


https://review.coreboot.org/#/c/29235/5/src/northbridge/amd/amdht/h3finit.h@436
PS5, Line 436: 	 *	@param[in,out]  u16 LinkFrequency  = modify to change the link's frequency capability
line over 80 characters


https://review.coreboot.org/#/c/29235/5/src/northbridge/amd/amdht/h3finit.h@462
PS5, Line 462: 	 *	@param[in]  u8  pEventData0 = useful data associated with the event.
line over 80 characters


https://review.coreboot.org/#/c/29235/5/src/northbridge/amd/amdht/h3ncmn.c
File src/northbridge/amd/amdht/h3ncmn.c:

https://review.coreboot.org/#/c/29235/5/src/northbridge/amd/amdht/h3ncmn.c@1201
PS5, Line 1201:  *	@param[in] targetNode  = The node  that shall be the recipient of the traffic
line over 80 characters


https://review.coreboot.org/#/c/29235/5/src/northbridge/amd/amdht/h3ncmn.c@1202
PS5, Line 1202:  *	@param[in] targetLink  = The link that shall be the recipient of the traffic
line over 80 characters



-- 
To view, visit https://review.coreboot.org/29235
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I65da8efa9a67b2915fbc0276ce800104198abcee
Gerrit-Change-Number: 29235
Gerrit-PatchSet: 5
Gerrit-Owner: Peter Lemenkov <lemenkov at gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Tue, 23 Oct 2018 11:53:27 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181023/52e15026/attachment.html>


More information about the coreboot-gerrit mailing list