[coreboot-gerrit] Change in coreboot[master]: mb/google/poppy: add the smi_events back

[Zhuohao Lee (Code Review)]

Zhuohao Lee has posted comments on this change. ( https://review.coreboot.org/29191 )

Change subject: mb/google/poppy: add the smi_events back
......................................................................


Patch Set 4:

(2 comments)

https://review.coreboot.org/#/c/29191/1//COMMIT_MSG
Commit Message:

https://review.coreboot.org/#/c/29191/1//COMMIT_MSG@12
PS1, Line 12: always keep in S0.
> Can you please mention here that this was broken because of CL:28983?
Done


https://review.coreboot.org/#/c/29191/1/src/mainboard/google/poppy/ec.c
File src/mainboard/google/poppy/ec.c:

https://review.coreboot.org/#/c/29191/1/src/mainboard/google/poppy/ec.c@27
PS1, Line 27: .smi_events = MAINBOARD_EC_SMI_EVENTS,
> Can you please do the same thing for nocturne: https://review.coreboot.org/cgit/coreboot. […]
Done. I don't have nocturne, need someone to help me double check on nocturne.



-- 
To view, visit https://review.coreboot.org/29191
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id82311a8ccd109f9c26516f59a45bdf34da98529
Gerrit-Change-Number: 29191
Gerrit-PatchSet: 4
Gerrit-Owner: Zhuohao Lee <zhuohao at chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro at google.com>
Gerrit-Reviewer: Zhuohao Lee <zhuohao at chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Tue, 23 Oct 2018 02:12:40 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181023/1dfb7365/attachment.html>