[coreboot-gerrit] Change in coreboot[master]: commonlib/region: Add region protect API

build bot (Jenkins) (Code Review) gerrit at coreboot.org
Mon Oct 22 13:48:56 CEST 2018


build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/28724 )

Change subject: commonlib/region: Add region protect API
......................................................................


Patch Set 5:

(1 comment)

https://review.coreboot.org/#/c/28724/5/src/commonlib/include/commonlib/region.h
File src/commonlib/include/commonlib/region.h:

https://review.coreboot.org/#/c/28724/5/src/commonlib/include/commonlib/region.h@97
PS5, Line 97: 	int (*protect)(const struct region *);
function definition argument 'const struct region *' should also have an identifier name



-- 
To view, visit https://review.coreboot.org/28724
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4c9376e2c2c7a4852f13c65824c6cd64a1c6ac0a
Gerrit-Change-Number: 28724
Gerrit-PatchSet: 5
Gerrit-Owner: Rizwan Qureshi <rizwan.qureshi at intel.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi at intel.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik at intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Comment-Date: Mon, 22 Oct 2018 11:48:56 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181022/356bc712/attachment.html>


More information about the coreboot-gerrit mailing list