[coreboot-gerrit] Change in coreboot[master]: intel: Use CF9 reset (part 2)

[Nico Huber (Code Review)]

Hello Patrick Rudolph, build bot (Jenkins), 

I'd like you to reexamine a change. Please visit

    https://review.coreboot.org/29169

to look at the new patch set (#3).

Change subject: intel: Use CF9 reset (part 2)
......................................................................

intel: Use CF9 reset (part 2)

Make use of the common CF9 reset in SOC_INTEL_COMMON_RESET. Also
implement board_reset() as a "full reset" (aka. cold reset) as that
is what was used here for hard_reset().

Drop soc_reset_prepare() thereby, as it was only used for APL. Also,
move the global-reset logic.

We leave some comments to remind us that a system_reset() should
be enough, where a full_reset() is called now (to retain current
behaviour) and looks suspicious.

Note, as no global_reset() is implemented for Denverton-NS, we halt
there now instead of issuing a non-global reset. This seems safer;
a non-global reset might result in a reset loop.

Change-Id: I5e7025c3c9ea6ded18e72037412b60a1df31bd53
Signed-off-by: Nico Huber <nico.h at gmx.de>
---
M src/drivers/intel/fsp1_1/raminit.c
M src/drivers/intel/fsp1_1/romstage.c
M src/drivers/intel/fsp2_0/memory_init.c
M src/drivers/intel/fsp2_0/util.c
D src/include/cpu/intel/reset.h
M src/include/reset.h
M src/lib/reset.c
M src/soc/intel/apollolake/Kconfig
M src/soc/intel/apollolake/reset.c
M src/soc/intel/apollolake/romstage.c
M src/soc/intel/braswell/Kconfig
M src/soc/intel/cannonlake/Kconfig
M src/soc/intel/cannonlake/reset.c
M src/soc/intel/common/Kconfig
M src/soc/intel/common/block/acpi/acpi.c
M src/soc/intel/common/reset.c
A src/soc/intel/common/reset.h
M src/soc/intel/denverton_ns/Kconfig
M src/soc/intel/denverton_ns/reset.c
M src/soc/intel/denverton_ns/romstage.c
M src/soc/intel/quark/Kconfig
M src/soc/intel/quark/reset.c
M src/soc/intel/skylake/Kconfig
M src/soc/intel/skylake/reset.c
24 files changed, 83 insertions(+), 108 deletions(-)


  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/69/29169/3
-- 
To view, visit https://review.coreboot.org/29169
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I5e7025c3c9ea6ded18e72037412b60a1df31bd53
Gerrit-Change-Number: 29169
Gerrit-PatchSet: 3
Gerrit-Owner: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181018/0261c4a2/attachment.html>