[coreboot-gerrit] Change in coreboot[master]: mainboard/intel/icelake_rvp: Initial mainboard commit

[build bot (Jenkins) (Code Review)]

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/29164 )

Change subject: mainboard/intel/icelake_rvp: Initial mainboard commit
......................................................................


Patch Set 2:

(12 comments)

https://review.coreboot.org/#/c/29164/2/src/mainboard/intel/icelake_rvp/chromeos.c
File src/mainboard/intel/icelake_rvp/chromeos.c:

https://review.coreboot.org/#/c/29164/2/src/mainboard/intel/icelake_rvp/chromeos.c@42
PS2, Line 42:         /* Lid always open */
code indent should use tabs where possible


https://review.coreboot.org/#/c/29164/2/src/mainboard/intel/icelake_rvp/chromeos.c@43
PS2, Line 43:         return 1;
code indent should use tabs where possible


https://review.coreboot.org/#/c/29164/2/src/mainboard/intel/icelake_rvp/chromeos.c@43
PS2, Line 43:         return 1;
please, no spaces at the start of a line


https://review.coreboot.org/#/c/29164/2/src/mainboard/intel/icelake_rvp/chromeos.c@48
PS2, Line 48:         return 0;
code indent should use tabs where possible


https://review.coreboot.org/#/c/29164/2/src/mainboard/intel/icelake_rvp/chromeos.c@48
PS2, Line 48:         return 0;
please, no spaces at the start of a line


https://review.coreboot.org/#/c/29164/2/src/mainboard/intel/icelake_rvp/spd/spd_util.c
File src/mainboard/intel/icelake_rvp/spd/spd_util.c:

https://review.coreboot.org/#/c/29164/2/src/mainboard/intel/icelake_rvp/spd/spd_util.c@26
PS2, Line 26: 		0x0F, 0xF0, 0x0F, 0xF0, 0xFF, 0x00 ,
space prohibited before that ',' (ctx:WxE)


https://review.coreboot.org/#/c/29164/2/src/mainboard/intel/icelake_rvp/variants/baseboard/gpio.c
File src/mainboard/intel/icelake_rvp/variants/baseboard/gpio.c:

https://review.coreboot.org/#/c/29164/2/src/mainboard/intel/icelake_rvp/variants/baseboard/gpio.c@314
PS2, Line 314:         CROS_GPIO_REC_AL(CROS_GPIO_VIRTUAL, CROS_GPIO_DEVICE_NAME),
code indent should use tabs where possible


https://review.coreboot.org/#/c/29164/2/src/mainboard/intel/icelake_rvp/variants/baseboard/gpio.c@314
PS2, Line 314:         CROS_GPIO_REC_AL(CROS_GPIO_VIRTUAL, CROS_GPIO_DEVICE_NAME),
please, no spaces at the start of a line


https://review.coreboot.org/#/c/29164/2/src/mainboard/intel/icelake_rvp/variants/baseboard/gpio.c@319
PS2, Line 319:         *num = ARRAY_SIZE(cros_gpios);
code indent should use tabs where possible


https://review.coreboot.org/#/c/29164/2/src/mainboard/intel/icelake_rvp/variants/baseboard/gpio.c@319
PS2, Line 319:         *num = ARRAY_SIZE(cros_gpios);
please, no spaces at the start of a line


https://review.coreboot.org/#/c/29164/2/src/mainboard/intel/icelake_rvp/variants/baseboard/gpio.c@320
PS2, Line 320:         return cros_gpios;
code indent should use tabs where possible


https://review.coreboot.org/#/c/29164/2/src/mainboard/intel/icelake_rvp/variants/baseboard/gpio.c@320
PS2, Line 320:         return cros_gpios;
please, no spaces at the start of a line



-- 
To view, visit https://review.coreboot.org/29164
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I875972d1fb2f630bf5eb29bd955c484e7f9aa415
Gerrit-Change-Number: 29164
Gerrit-PatchSet: 2
Gerrit-Owner: Aamir Bohra <aamir.bohra at intel.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik at intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Wed, 17 Oct 2018 13:21:47 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181017/149cad66/attachment.html>