[coreboot-gerrit] Change in coreboot[master]: arch/x86/exception: Improve the readability of a comment

Patrick Georgi (Code Review) gerrit at coreboot.org
Wed Oct 17 14:01:53 CEST 2018


Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/28993 )

Change subject: arch/x86/exception: Improve the readability of a comment
......................................................................

arch/x86/exception: Improve the readability of a comment

Add punctuation and fix a typo.

Change-Id: Ic61c665f7e2daefb50b478a1710ea66c8a88235a
Signed-off-by: Jonathan Neuschäfer <j.neuschaefer at gmx.net>
Reviewed-on: https://review.coreboot.org/28993
Tested-by: build bot (Jenkins) <no-reply at coreboot.org>
Reviewed-by: Angel Pons <th3fanbus at gmail.com>
---
M src/arch/x86/exception.c
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Angel Pons: Looks good to me, approved



diff --git a/src/arch/x86/exception.c b/src/arch/x86/exception.c
index a281c54..0f42fdf 100644
--- a/src/arch/x86/exception.c
+++ b/src/arch/x86/exception.c
@@ -554,8 +554,8 @@
 
 /* Even though the vecX symbols are interrupt entry points just treat them
    like data to more easily get the pointer values in C. Because IDT entries
-   format splits the offset field up one can't use the linker to resolve
-   parts of a relecation on x86 ABI an array of pointers is used to gather
+   format splits the offset field up, one can't use the linker to resolve
+   parts of a relocation on x86 ABI. An array of pointers is used to gather
    the symbols. The IDT is initialized at runtime when exception_init() is
    called. */
 extern u8 vec0[], vec1[], vec2[], vec3[], vec4[], vec5[], vec6[], vec7[];

-- 
To view, visit https://review.coreboot.org/28993
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic61c665f7e2daefb50b478a1710ea66c8a88235a
Gerrit-Change-Number: 28993
Gerrit-PatchSet: 2
Gerrit-Owner: Jonathan Neuschäfer <j.neuschaefer at gmx.net>
Gerrit-Reviewer: Angel Pons <th3fanbus at gmail.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181017/ca439679/attachment.html>


More information about the coreboot-gerrit mailing list