[coreboot-gerrit] Change in coreboot[master]: cpu/amd: Use common AMD's MSR

[build bot (Jenkins) (Code Review)]

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/29065 )

Change subject: cpu/amd: Use common AMD's MSR
......................................................................


Patch Set 11:

(15 comments)

https://review.coreboot.org/#/c/29065/11/src/cpu/amd/agesa/family14/fixme.c
File src/cpu/amd/agesa/family14/fixme.c:

https://review.coreboot.org/#/c/29065/11/src/cpu/amd/agesa/family14/fixme.c@99
PS11, Line 99: 	LibAmdMsrWrite (PS_CTL_REG, &MsrReg, &StdHeader);
space prohibited between function name and open parenthesis '('


https://review.coreboot.org/#/c/29065/11/src/cpu/amd/agesa/family15tn/fixme.c
File src/cpu/amd/agesa/family15tn/fixme.c:

https://review.coreboot.org/#/c/29065/11/src/cpu/amd/agesa/family15tn/fixme.c@75
PS11, Line 75: 	LibAmdMsrWrite (MMIO_CONF_BASE, &MsrReg, &StdHeader);
space prohibited between function name and open parenthesis '('


https://review.coreboot.org/#/c/29065/11/src/cpu/amd/agesa/family16kb/fixme.c
File src/cpu/amd/agesa/family16kb/fixme.c:

https://review.coreboot.org/#/c/29065/11/src/cpu/amd/agesa/family16kb/fixme.c@75
PS11, Line 75: 	LibAmdMsrWrite (MMIO_CONF_BASE, &MsrReg, &StdHeader);
space prohibited between function name and open parenthesis '('


https://review.coreboot.org/#/c/29065/11/src/cpu/amd/family_10h-family_15h/defaults.h
File src/cpu/amd/family_10h-family_15h/defaults.h:

https://review.coreboot.org/#/c/29065/11/src/cpu/amd/family_10h-family_15h/defaults.h@77
PS11, Line 77: 	{ NB_CFG_MSR, (AMD_FAM10_ALL | AMD_FAM15_ALL), AMD_PTYPE_DC | AMD_PTYPE_MC,
line over 80 characters


https://review.coreboot.org/#/c/29065/11/src/cpu/amd/family_10h-family_15h/defaults.h@107
PS11, Line 107: 	  1 << 21, 0x00000000 },	/* Erratum #254 DR B1 BU_CFG_MSR[21]=1 */
line over 80 characters


https://review.coreboot.org/#/c/29065/11/src/cpu/amd/family_10h-family_15h/defaults.h@118
PS11, Line 118: 	{ CPU_ID_FEATURES_MSR, (AMD_FAM10_ALL | AMD_FAM15_ALL), AMD_PTYPE_DC | AMD_PTYPE_MC,
line over 80 characters


https://review.coreboot.org/#/c/29065/11/src/cpu/amd/family_10h-family_15h/fidvid.c
File src/cpu/amd/family_10h-family_15h/fidvid.c:

https://review.coreboot.org/#/c/29065/11/src/cpu/amd/family_10h-family_15h/fidvid.c@155
PS11, Line 155: 		wrmsr(PSTATE_0_MSR , msr);
space prohibited before that ',' (ctx:WxW)


https://review.coreboot.org/#/c/29065/11/src/cpu/amd/family_10h-family_15h/fidvid.c@227
PS11, Line 227: 				wrmsr(PS_MIN_REG, rdmsr(PS_MAX_REG) );
space prohibited before that close parenthesis ')'


https://review.coreboot.org/#/c/29065/11/src/cpu/amd/family_10h-family_15h/fidvid.c@335
PS11, Line 335: 	if (!(msr.hi & 0x80000000)) {
suspect code indent for conditional statements (8, 12)


https://review.coreboot.org/#/c/29065/11/src/cpu/amd/family_10h-family_15h/fidvid.c@336
PS11, Line 336: 	    printk(BIOS_ERR,"P-state info in MSR%8x is invalid !!!\n",
space required after that ',' (ctx:VxV)


https://review.coreboot.org/#/c/29065/11/src/include/cpu/amd/msr.h
File src/include/cpu/amd/msr.h:

https://review.coreboot.org/#/c/29065/11/src/include/cpu/amd/msr.h@40
PS11, Line 40: #define PS_CTL_REG			0xC0010062 /* P-state Control Register */
line over 80 characters


https://review.coreboot.org/#/c/29065/11/src/include/cpu/amd/msr.h@41
PS11, Line 41: #define  PS_CMD_MASK_OFF		0xfffffff8 /* P-state Control Register CMD Mask OFF */
line over 80 characters


https://review.coreboot.org/#/c/29065/11/src/include/cpu/amd/msr.h@43
PS11, Line 43: #define PS_MAX_REG			0xC0010068 /* Maximum P-State Register */
line over 80 characters


https://review.coreboot.org/#/c/29065/11/src/include/cpu/amd/msr.h@44
PS11, Line 44: #define PS_MIN_REG			0xC0010064 /* Mimimum P-State Register */
line over 80 characters


https://review.coreboot.org/#/c/29065/11/src/northbridge/amd/amdmct/mct_ddr3/mctsrc.c
File src/northbridge/amd/amdmct/mct_ddr3/mctsrc.c:

https://review.coreboot.org/#/c/29065/11/src/northbridge/amd/amdmct/mct_ddr3/mctsrc.c@672
PS11, Line 672: 	wrmsr(HWCR_MSR, msr);	/* Setting wrap32dis allows 64-bit memory references in real mode */
line over 80 characters



-- 
To view, visit https://review.coreboot.org/29065
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0236e0960cd1e79558ea50c814e1de2830aa0550
Gerrit-Change-Number: 29065
Gerrit-PatchSet: 11
Gerrit-Owner: Elyes HAOUAS <ehaouas at noos.fr>
Gerrit-Reviewer: Elyes HAOUAS <ehaouas at noos.fr>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd at gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Richard Spiegel <richard.spiegel at silverbackltd.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Marc Jones <marc at marcjonesconsulting.com>
Gerrit-Comment-Date: Wed, 17 Oct 2018 06:32:59 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181017/057561b9/attachment.html>