[coreboot-gerrit] Change in coreboot[master]: ec/google/wilco: Add mailbox commands

[Duncan Laurie (Code Review)]

Duncan Laurie has uploaded this change for review. ( https://review.coreboot.org/29115


Change subject: ec/google/wilco: Add mailbox commands
......................................................................

ec/google/wilco: Add mailbox commands

Add basic supported mailbox commands for this embedded contrlller,
and define some command functions to retrieve and print information
about the EC.

Change-Id: Ibcef7d58e1852fdb2e52b97acd4b51a26dd8cd77
Signed-off-by: Duncan Laurie <dlaurie at google.com>
---
M src/ec/google/wilco/Makefile.inc
A src/ec/google/wilco/commands.c
A src/ec/google/wilco/commands.h
3 files changed, 107 insertions(+), 1 deletion(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/15/29115/1

diff --git a/src/ec/google/wilco/Makefile.inc b/src/ec/google/wilco/Makefile.inc
index 6130f6f..68172e3 100644
--- a/src/ec/google/wilco/Makefile.inc
+++ b/src/ec/google/wilco/Makefile.inc
@@ -1,5 +1,5 @@
 ifeq ($(CONFIG_EC_GOOGLE_WILCO),y)
 
-ramstage-y += mailbox.c
+ramstage-y += commands.c mailbox.c
 
 endif
diff --git a/src/ec/google/wilco/commands.c b/src/ec/google/wilco/commands.c
new file mode 100644
index 0000000..4cec58b
--- /dev/null
+++ b/src/ec/google/wilco/commands.c
@@ -0,0 +1,52 @@
+/*
+ * This file is part of the coreboot project.
+ *
+ * Copyright 2018 Google LLC
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; version 2 of the License
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ */
+
+#include <console/console.h>
+#include <stdint.h>
+#include <string.h>
+
+#include "ec.h"
+#include "commands.h"
+
+int wilco_ec_get_info(enum get_ec_info_cmd type, char *info)
+{
+	struct ec_response_get_ec_info rsp;
+
+	if (!info)
+		return -1;
+	if (wilco_ec_sendrecv(KB_EC_INFO, type, &rsp, sizeof(rsp)) < 0)
+		return -1;
+
+	/* Copy returned string */
+	strncpy(info, rsp.data, sizeof(rsp));
+	return 0;
+}
+
+void wilco_ec_print_info(void)
+{
+	char info[EC_INFO_MAX_SIZE];
+
+	if (!wilco_ec_get_info(GET_EC_LABEL, info))
+		printk(BIOS_INFO, "EC Label      : %s\n", info);
+
+	if (!wilco_ec_get_info(GET_EC_SVN_REV, info))
+		printk(BIOS_INFO, "EC Revision   : %s\n", info);
+
+	if (!wilco_ec_get_info(GET_EC_MODEL_NO, info))
+		printk(BIOS_INFO, "EC Model Num  : %s\n", info);
+
+	if (!wilco_ec_get_info(GET_EC_BUILD_DATE, info))
+		printk(BIOS_INFO, "EC Build Date : %s\n", info);
+}
diff --git a/src/ec/google/wilco/commands.h b/src/ec/google/wilco/commands.h
new file mode 100644
index 0000000..76949d0
--- /dev/null
+++ b/src/ec/google/wilco/commands.h
@@ -0,0 +1,54 @@
+/*
+ * This file is part of the coreboot project.
+ *
+ * Copyright 2018 Google LLC
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; version 2 of the License.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ */
+
+#ifndef EC_GOOGLE_WILCO_COMMANDS_H
+#define EC_GOOGLE_WILCO_COMMANDS_H
+
+#include <stdint.h>
+
+enum {
+	/* Retrieve information about the EC */
+	KB_EC_INFO = 0x38,
+	/* Set ACPI mode on or off */
+	KB_ACPI = 0x3a,
+	/* Manage the EC power button passthru to the host */
+	KB_POWER_BUTTON_TO_HOST = 0x3e,
+};
+
+enum set_acpi_mode_cmd {
+	ACPI_OFF = 0,
+	ACPI_ON
+};
+
+/*
+ * EC Information
+ */
+
+enum get_ec_info_cmd {
+	GET_EC_LABEL = 0,
+	GET_EC_SVN_REV,
+	GET_EC_MODEL_NO,
+	GET_EC_BUILD_DATE
+};
+
+#define EC_INFO_MAX_SIZE 9
+struct ec_response_get_ec_info {
+	char data[EC_INFO_MAX_SIZE]; /* ascii null-terminated string */
+};
+
+int wilco_ec_get_info(enum get_ec_info_cmd cmd, char *info);
+void wilco_ec_print_info(void);
+
+#endif /* EC_GOOGLE_WILCO_COMMANDS_H */

-- 
To view, visit https://review.coreboot.org/29115
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibcef7d58e1852fdb2e52b97acd4b51a26dd8cd77
Gerrit-Change-Number: 29115
Gerrit-PatchSet: 1
Gerrit-Owner: Duncan Laurie <dlaurie at chromium.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181015/7f368cf4/attachment-0001.html>