[coreboot-gerrit] Change in coreboot[master]: mb/google/octopus: Check for invalid pin termination settings

build bot (Jenkins) (Code Review) gerrit at coreboot.org
Tue Oct 16 00:42:44 CEST 2018


build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/29110 )

Change subject: mb/google/octopus: Check for invalid pin termination settings
......................................................................


Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/29110/1/src/soc/intel/common/block/include/intelblocks/gpio_defs.h
File src/soc/intel/common/block/include/intelblocks/gpio_defs.h:

https://review.coreboot.org/#/c/29110/1/src/soc/intel/common/block/include/intelblocks/gpio_defs.h@157
PS1, Line 157: 			__config1) ? __config1: 0xFFFFFFFFFF, \
spaces required around that ':' (ctx:VxW)



-- 
To view, visit https://review.coreboot.org/29110
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I64317e75f27e4cc2faf88b640b1bf9401db59dec
Gerrit-Change-Number: 29110
Gerrit-PatchSet: 1
Gerrit-Owner: Shamile Khan <shamile.khan at intel.com>
Gerrit-CC: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Mon, 15 Oct 2018 22:42:44 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181015/ae24829a/attachment.html>


More information about the coreboot-gerrit mailing list