[coreboot-gerrit] Change in coreboot[master]: riscv: add support smp_pause / smp_resume

build bot (Jenkins) (Code Review) gerrit at coreboot.org
Mon Oct 15 17:28:39 CEST 2018


build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/29023 )

Change subject: riscv: add support smp_pause / smp_resume
......................................................................


Patch Set 14:

(4 comments)

https://review.coreboot.org/#/c/29023/14/src/arch/riscv/smp.c
File src/arch/riscv/smp.c:

https://review.coreboot.org/#/c/29023/14/src/arch/riscv/smp.c@47
PS14, Line 47:           	/* Initialize the counter and mark the work hart into smp_pause */
line over 80 characters


https://review.coreboot.org/#/c/29023/14/src/arch/riscv/smp.c@47
PS14, Line 47:           	/* Initialize the counter and mark the work hart into smp_pause */
code indent should use tabs where possible


https://review.coreboot.org/#/c/29023/14/src/arch/riscv/smp.c@47
PS14, Line 47:           	/* Initialize the counter and mark the work hart into smp_pause */
please, no space before tabs


https://review.coreboot.org/#/c/29023/14/src/arch/riscv/smp.c@47
PS14, Line 47:           	/* Initialize the counter and mark the work hart into smp_pause */
please, no spaces at the start of a line



-- 
To view, visit https://review.coreboot.org/29023
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6f8159637bfb15f54f0abeb335de2ba6e9cf82fb
Gerrit-Change-Number: 29023
Gerrit-PatchSet: 14
Gerrit-Owner: Xiang Wang <wxjstz at 126.com>
Gerrit-Reviewer: Jonathan Neuschäfer <j.neuschaefer at gmx.net>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Philipp Hug <philipp at hug.cx>
Gerrit-Reviewer: Shawn Chang <citypw at gmail.com>
Gerrit-Reviewer: Xiang Wang <wxjstz at 126.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Mon, 15 Oct 2018 15:28:39 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181015/2c79bc5c/attachment.html>


More information about the coreboot-gerrit mailing list