[coreboot-gerrit] Change in coreboot[master]: riscv: add support smp_pause / smp_resume

[Philipp Hug (Code Review)]

Philipp Hug has posted comments on this change. ( https://review.coreboot.org/29023 )

Change subject: riscv: add support smp_pause / smp_resume
......................................................................


Patch Set 7:

(3 comments)

Thanks!

https://review.coreboot.org/#/c/29023/7/src/arch/riscv/include/mcall.h
File src/arch/riscv/include/mcall.h:

https://review.coreboot.org/#/c/29023/7/src/arch/riscv/include/mcall.h@72
PS7, Line 72: /* This function is used to operate msip by memory-mapped */
Can you clarify this comment?


https://review.coreboot.org/#/c/29023/7/src/arch/riscv/smp.c
File src/arch/riscv/smp.c:

https://review.coreboot.org/#/c/29023/7/src/arch/riscv/smp.c@22
PS7, Line 22: void smp_pause(void)
Could you add some comments here, especially that this function never returns.


https://review.coreboot.org/#/c/29023/7/src/arch/riscv/smp.c@24
PS7, Line 24: 	if (read_csr(mhartid) == 0)
Can we move this check outside of this function to make the flow clearer?
Also the hart executing coreboot doesn't necessarily have to be 0



-- 
To view, visit https://review.coreboot.org/29023
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6f8159637bfb15f54f0abeb335de2ba6e9cf82fb
Gerrit-Change-Number: 29023
Gerrit-PatchSet: 7
Gerrit-Owner: Xiang Wang <wxjstz at 126.com>
Gerrit-Reviewer: Jonathan Neuschäfer <j.neuschaefer at gmx.net>
Gerrit-Reviewer: Philipp Hug <philipp at hug.cx>
Gerrit-Reviewer: Shawn Chang <citypw at gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Mon, 15 Oct 2018 09:14:24 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181015/5672108f/attachment.html>