[coreboot-gerrit] Change in coreboot[master]: mb/asus/p5q_pro: Add mainboard

[Felix Held (Code Review)]

Felix Held has posted comments on this change. ( https://review.coreboot.org/29102 )

Change subject: mb/asus/p5q_pro: Add mainboard
......................................................................


Patch Set 2: Code-Review+1

(2 comments)

https://review.coreboot.org/#/c/29102/2/src/mainboard/asus/p5qc/variants/p5q_pro/devicetree.cb
File src/mainboard/asus/p5qc/variants/p5q_pro/devicetree.cb:

https://review.coreboot.org/#/c/29102/2/src/mainboard/asus/p5qc/variants/p5q_pro/devicetree.cb@65
PS2, Line 65: ISA
LPC


https://review.coreboot.org/#/c/29102/2/src/mainboard/asus/p5qc/variants/p5q_pro/devicetree.cb@111
PS2, Line 111: # IRQ purposefully not assigned to prevent lockups
maybe set it explicitly to 0? that's the default value



-- 
To view, visit https://review.coreboot.org/29102
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I49a4bca4256e2a905aff3252eca76387c81152c1
Gerrit-Change-Number: 29102
Gerrit-PatchSet: 2
Gerrit-Owner: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Angel Pons <th3fanbus at gmail.com>
Gerrit-Reviewer: Felix Held <felix-coreboot at felixheld.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Sun, 14 Oct 2018 14:04:26 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181014/d32dce1e/attachment.html>