[coreboot-gerrit] Change in coreboot[master]: libpayload: Add HID mouse support

build bot (Jenkins) (Code Review) gerrit at coreboot.org
Sun Oct 14 16:01:33 CEST 2018


build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/18598 )

Change subject: libpayload: Add HID mouse support
......................................................................


Patch Set 7:

(2 comments)

https://review.coreboot.org/#/c/18598/7/payloads/libpayload/drivers/usb/usbhid.c
File payloads/libpayload/drivers/usb/usbhid.c:

https://review.coreboot.org/#/c/18598/7/payloads/libpayload/drivers/usb/usbhid.c@431
PS7, Line 431: 	while((buf = dev->controller->poll_intr_queue (HID_INST(dev)->queue))) {
space prohibited between function name and open parenthesis '('


https://review.coreboot.org/#/c/18598/7/payloads/libpayload/drivers/usb/usbhid.c@431
PS7, Line 431: 	while((buf = dev->controller->poll_intr_queue (HID_INST(dev)->queue))) {
space required before the open parenthesis '('



-- 
To view, visit https://review.coreboot.org/18598
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibce251d77f7ccc85e17d42fc471b14d294c0c3e9
Gerrit-Change-Number: 18598
Gerrit-PatchSet: 7
Gerrit-Owner: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: Julius Werner <jwerner at chromium.org>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph at 9elements.com>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Sun, 14 Oct 2018 14:01:33 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181014/59fa0b82/attachment.html>


More information about the coreboot-gerrit mailing list